Skip to content

Adding Drivenets in vendor list and config APIs#123

Open
mionescu-dn wants to merge 3 commits intoopenconfig:mainfrom
drivenets:dn_vendor
Open

Adding Drivenets in vendor list and config APIs#123
mionescu-dn wants to merge 3 commits intoopenconfig:mainfrom
drivenets:dn_vendor

Conversation

@mionescu-dn
Copy link

No description provided.

Signed-off-by: Marius Ionescu <mionescu@drivenets.com>
Signed-off-by: Marius Ionescu <mionescu@drivenets.com>
@supl
Copy link

supl commented Jan 31, 2025

@mionescu-dn Ionescu, Thank you for your updates.
Sorry for bothering you.
I also left a comment in Noam's PR #115 (comment)
I wonder if it's possible to support DriveNets in the KNE binding part.

Thank you!

otherwise topology parse will remove Drivenets devices.

Signed-off-by: Marius Ionescu <mionescu@drivenets.com>
@mionescu-dn
Copy link
Author

@mionescu-dn Ionescu, Thank you for your updates. Sorry for bothering you. I also left a comment in Noam's PR #115 (comment) I wonder if it's possible to support DriveNets in the KNE binding part.

Thank you!

Hi Plenty,

I appreciate your comment on this PR.
I’ve added an additional patch to this series for solver.go.

We’re currently working on providing compatibility with Ondatra and FeatureProfiles APIs.
This patch serves as a prerequisite for enabling FeatureProfiles static binding without the need for a custom Ondatra branch.

@supl
Copy link

supl commented Feb 3, 2025

@mionescu-dn Ionescu, Thank you for your updates. Sorry for bothering you. I also left a comment in Noam's PR #115 (comment) I wonder if it's possible to support DriveNets in the KNE binding part.
Thank you!

Hi Plenty,

I appreciate your comment on this PR. I’ve added an additional patch to this series for solver.go.

We’re currently working on providing compatibility with Ondatra and FeatureProfiles APIs. This patch serves as a prerequisite for enabling FeatureProfiles static binding without the need for a custom Ondatra branch.

Thank you very much.

@dplore
Copy link
Member

dplore commented Mar 21, 2025

@mionescu-dn can you resolve the conflicts? I've asked @bstoll to help review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants