Add insecure binding for testing to knebind#64
Open
burnyd wants to merge 1 commit intoopenconfig:mainfrom
Open
Add insecure binding for testing to knebind#64burnyd wants to merge 1 commit intoopenconfig:mainfrom
burnyd wants to merge 1 commit intoopenconfig:mainfrom
Conversation
Contributor
|
Sorry, @burnyd, that I completely lost track of this. Would you still find something like this useful/needed? |
marcushines
reviewed
Aug 7, 2023
|
|
||
| func (d *kneDUT) DialGNMI(ctx context.Context, opts ...grpc.DialOption) (gpb.GNMIClient, error) { | ||
| //If the insecure field is set to true then set to insecure | ||
| if d.cfg.Insecure { |
Contributor
There was a problem hiding this comment.
this feels like someting that should really be on the testbed as an option not on the bind
Either per testbed or per dut this would be set
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating this small PR to allow the knebind functionality to allow insecure grpc connections without a cert for testing purposes.