Skip to content
This repository was archived by the owner on Oct 2, 2025. It is now read-only.

Conversation

@dcoa
Copy link
Contributor

@dcoa dcoa commented Mar 12, 2025

This PR updates react-unit-test-utils with the compatibility for CSS Variables and Design Tokens, the new styling paradigm for the frontend.

Changes:

  1. Update paragon to a version 23.x
  2. Update frontend-platform to a version 8.3.x

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 12, 2025
@dcoa dcoa requested a review from brian-smith-tcril March 12, 2025 04:33
@codecov
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.03%. Comparing base (0eca27c) to head (3f27231).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #40   +/-   ##
=======================================
  Coverage   87.03%   87.03%           
=======================================
  Files           7        7           
  Lines          54       54           
  Branches        5        5           
=======================================
  Hits           47       47           
  Misses          7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@brian-smith-tcril
Copy link
Contributor

Thank you so much for catching this and making the PR!

It looks like the package.json still has frontend-platform at ^8.0.0. I think updating that to be ^8.3.1 would better communicate intent.

@dcoa dcoa force-pushed the dcoa/design-tokens-support branch from 96a0af1 to 1068a9d Compare March 13, 2025 01:16
@dcoa
Copy link
Contributor Author

dcoa commented Mar 13, 2025

@brian-smith-tcril I updated the dependency

@brian-smith-tcril
Copy link
Contributor

Thanks for updating that @dcoa! Sorry to ask for another change but would you mind updating this so the dev deps and peer dep versions for frontend-build and frontend-platform match? I think keeping them mismatched wouldn't cause any major issues, but it'd be nice to have them in sync for this PR.

@dcoa dcoa force-pushed the dcoa/design-tokens-support branch from 1068a9d to 4e7ae8d Compare March 14, 2025 10:14
@dcoa
Copy link
Contributor Author

dcoa commented Mar 14, 2025

Sure :) I made the change @brian-smith-tcril

package.json Outdated
"@openedx/frontend-build": "^14.0.0",
"@openedx/paragon": "^21.5.7 || ^22.0.0",
"@edx/frontend-platform": "^8.3.1",
"@openedx/frontend-build": "14.1.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"@openedx/frontend-build": "14.1.0",
"@openedx/frontend-build": "^14.1.0",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solved, sorry.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries! Thanks! Approved!

@brian-smith-tcril brian-smith-tcril merged commit 5f44809 into openedx-unsupported:main Mar 17, 2025
6 checks passed
@edx-semantic-release
Copy link

🎉 This PR is included in version 3.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

open-source-contribution PR author is not from Axim or 2U released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants