Add support for Python 3.12 & Django 5.2#577
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #577 +/- ##
==========================================
+ Coverage 94.67% 94.81% +0.13%
==========================================
Files 32 33 +1
Lines 3269 3315 +46
Branches 126 127 +1
==========================================
+ Hits 3095 3143 +48
+ Misses 156 154 -2
Partials 18 18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This change will affect the edx-platform, so we need to test this PR there as well before merging. |
edxval/utils.py
Outdated
| # during edx-platform loading this method gets called but settings are not ready yet | ||
| # so in that case we will return default(FileSystemStorage) storage class instance | ||
| return get_storage_class()() | ||
| return storages['default'] |
There was a problem hiding this comment.
This change will take effect immediately after the merge.
f6f89f9 to
668fd92
Compare
|
Created a PR here openedx/openedx-platform#36658 to test it in edx-platform. |
ce930da to
1c69cdd
Compare
|
Looks like you might need to rebuild the pact tests? |
|
@irtazaakram, since you're creating the PR from a fork, the Pact test is failing. Good to go. |
Major Change: openedx/public-engineering#340