Skip to content

Add support for Python 3.12 & Django 5.2#577

Merged
feanil merged 2 commits intoopenedx:masterfrom
irtazaakram:update-python-django
May 14, 2025
Merged

Add support for Python 3.12 & Django 5.2#577
feanil merged 2 commits intoopenedx:masterfrom
irtazaakram:update-python-django

Conversation

@irtazaakram
Copy link
Member

@irtazaakram irtazaakram requested a review from awais786 April 14, 2025 12:33
@codecov
Copy link

codecov bot commented Apr 14, 2025

Codecov Report

Attention: Patch coverage is 96.29630% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.81%. Comparing base (eabb63a) to head (6800b99).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
edxval/tests/test_storages.py 95.23% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #577      +/-   ##
==========================================
+ Coverage   94.67%   94.81%   +0.13%     
==========================================
  Files          32       33       +1     
  Lines        3269     3315      +46     
  Branches      126      127       +1     
==========================================
+ Hits         3095     3143      +48     
+ Misses        156      154       -2     
  Partials       18       18              
Flag Coverage Δ
unittests 94.81% <96.29%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@awais786
Copy link
Contributor

This change will affect the edx-platform, so we need to test this PR there as well before merging.

edxval/utils.py Outdated
# during edx-platform loading this method gets called but settings are not ready yet
# so in that case we will return default(FileSystemStorage) storage class instance
return get_storage_class()()
return storages['default']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change will take effect immediately after the merge.

@irtazaakram
Copy link
Member Author

Created a PR here openedx/openedx-platform#36658 to test it in edx-platform.

@irtazaakram irtazaakram force-pushed the update-python-django branch from ce930da to 1c69cdd Compare May 7, 2025 12:27
@irtazaakram irtazaakram requested a review from feanil May 12, 2025 05:18
@feanil
Copy link
Contributor

feanil commented May 12, 2025

Looks like you might need to rebuild the pact tests?

@awais786
Copy link
Contributor

@irtazaakram, since you're creating the PR from a fork, the Pact test is failing. Good to go.

@feanil feanil merged commit f9a18f2 into openedx:master May 14, 2025
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Django 5.2 support to edx-val Drop Python 3.8 & Add Support for Python 3.12

4 participants