Skip to content

Conversation

@brian-smith-tcril
Copy link
Contributor

@brian-smith-tcril brian-smith-tcril commented Oct 31, 2025

Note

Why this is a draft

Depends on

Currently has an npm packed version of Paragon checked in.

Description

This PR updates the Paragon cards used in studio home to no longer rely on custom styles for header spacing.

openedx/paragon#3966 updates the styles in Paragon to better support this use case, this PR takes advantage of those changes.

Warning

Possible breaking changes for theme authors

  • Changes from Paragon
  • .card-item.pgn__card-header
    • No longer adds padding (was .9375rem 1.25rem)
  • .card-item.pgn__card-header-content
    • No longer modifies margin (was set to 0)
    • No longer sets overflow: hidden
  • .card-item.pgn__card-header-actions
    • No longer sets display: flex (now set in Paragon)
    • No longer sets align-items: center
    • No longer sets justify-content: center (now set in Paragon)
    • No longer sets margin: 0
Before After
image image

Supporting information

Testing instructions

Please provide detailed step-by-step instructions for manually testing this change.

Other information

Include anything else that will help reviewers and consumers understand the change.

  • Does this change depend on other changes elsewhere?
  • Any special concerns or limitations? For example: deprecations, migrations, security, or accessibility.

Best Practices Checklist

We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:

  • Any new files are using TypeScript (.ts, .tsx).
  • Avoid propTypes and defaultProps in any new or modified code.
  • Tests should use the helpers in src/testUtils.tsx (specifically initializeMocks)
  • Do not add new fields to the Redux state/store. Use React Context to share state among multiple components.
  • Use React Query to load data from REST APIs. See any apiHooks.ts in this repo for examples.
  • All new i18n messages in messages.ts files have a description for translators to use.
  • Avoid using ../ in import paths. To import from parent folders, use @src, e.g. import { initializeMocks } from '@src/testUtils'; instead of from '../../../../testUtils'

@brian-smith-tcril brian-smith-tcril added the create-sandbox open-craft-grove should create a sandbox environment from this PR label Oct 31, 2025
@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.81%. Comparing base (36c9eba) to head (d7cff8e).

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #2590    +/-   ##
========================================
  Coverage   94.81%   94.81%            
========================================
  Files        1225     1225            
  Lines       27481    27481            
  Branches     6187     6026   -161     
========================================
  Hits        26056    26056            
  Misses       1367     1367            
  Partials       58       58            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@open-craft-grove
Copy link

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

create-sandbox open-craft-grove should create a sandbox environment from this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants