Skip to content

style: Update some texts in legacy libraries migration flow [FC-0112] #2601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2025
Merged

style: Update some texts in legacy libraries migration flow [FC-0112] #2601

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/legacy-libraries-migration/ConfirmationView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@ export const ConfirmationView = ({
{...messages.confirmationViewAlert}
values={{
count: legacyLibraries.length,
libraryName: destination.title,
b: BoldText,
}}
/>
Expand Down
18 changes: 4 additions & 14 deletions src/legacy-libraries-migration/LegacyLibMigrationPage.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,14 +245,11 @@ describe('<LegacyLibMigrationPage />', () => {
await user.click(nextButton);
const alert = await screen.findByRole('alert');
expect(await within(alert).findByText(
/All content from the 1 legacy library you selected will be migrated to/i,
)).toBeInTheDocument();
expect(await within(alert).findByText(
/test library 1/i,
/All content from the legacy library you selected will be migrated to the Content Library you select/i,
)).toBeInTheDocument();

const backButton = screen.getByRole('button', { name: /back/i });
backButton.click();
await user.click(backButton);

expect(await screen.findByText('Test Library 1')).toBeInTheDocument();
// The selected v2 library remains checked
Expand Down Expand Up @@ -357,10 +354,7 @@ describe('<LegacyLibMigrationPage />', () => {
// Should show alert of ConfirmationView
const alert = await screen.findByRole('alert');
expect(await within(alert).findByText(
/All content from the 3 legacy libraries you selected will be migrated to/i,
)).toBeInTheDocument();
expect(await within(alert).findByText(
/test library 1/i,
/All content from the 3 legacy libraries you selected will be migrated to the Content Library you select/i,
)).toBeInTheDocument();
expect(screen.getByText('MBA')).toBeInTheDocument();
expect(screen.getByText('Legacy library 1')).toBeInTheDocument();
Expand Down Expand Up @@ -417,11 +411,7 @@ describe('<LegacyLibMigrationPage />', () => {
// Should show alert of ConfirmationView
const alert = await screen.findByRole('alert');
expect(await within(alert).findByText(
/All content from the 3 legacy libraries you selected will be migrated to /i,
{ exact: false },
)).toBeInTheDocument();
expect(await within(alert).findByText(
/test library 1/i,
/All content from the 3 legacy libraries you selected will be migrated to the Content Library you select/i,
{ exact: false },
)).toBeInTheDocument();
expect(screen.getByText('MBA')).toBeInTheDocument();
Expand Down
6 changes: 3 additions & 3 deletions src/legacy-libraries-migration/messages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ const messages = defineMessages({
selectDestinationAlert: {
id: 'legacy-libraries-migration.select-destination.alert.text',
defaultMessage: 'All content from the'
+ ' {count, plural, one {{count} legacy library} other {{count} legacy libraries}} you selected will'
+ ' {count, plural, one {legacy library} other {{count} legacy libraries}} you selected will'
+ ' be migrated to this new library, organized into collections. Legacy library content used in courses will'
+ ' continue to work as-is. To receive any future changes to migrated content, you must update these'
+ ' references within your course.',
Expand All @@ -73,8 +73,8 @@ const messages = defineMessages({
confirmationViewAlert: {
id: 'legacy-libraries-migration.select-destination.alert.text',
defaultMessage: 'All content from the'
+ ' {count, plural, one {{count} legacy library} other {{count} legacy libraries}} you selected will'
+ ' be migrated to <b>{libraryName}</b>, organized into collections. Legacy library content used in courses will'
+ ' {count, plural, one {legacy library} other {{count} legacy libraries}} you selected will'
+ ' be migrated to the Content Library you select, organized into collections. Legacy library content used in courses will'
+ ' continue to work as-is. To receive any future changes to migrated content, you must update these'
+ ' references within your course.',
description: 'Alert text in the confirmation step of the legacy libraries migration page.',
Expand Down