Skip to content

chore: update base route path to match old paths#797

Open
holaontiveros wants to merge 2 commits intoopenedx:frontend-basefrom
WGU-Open-edX:feb/base-route-path
Open

chore: update base route path to match old paths#797
holaontiveros wants to merge 2 commits intoopenedx:frontend-basefrom
WGU-Open-edX:feb/base-route-path

Conversation

@holaontiveros
Copy link

This will make the base route to match the old paths, which will alow to switch between MFE / frontendapps easily

@openedx-webhooks
Copy link

openedx-webhooks commented Feb 13, 2026

Thanks for the pull request, @holaontiveros!

This repository is currently maintained by @2U-aperture.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 13, 2026
@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Feb 13, 2026
@codecov
Copy link

codecov bot commented Feb 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (frontend-base@35283df). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             frontend-base     #797   +/-   ##
================================================
  Coverage                 ?   88.58%           
================================================
  Files                    ?      158           
  Lines                    ?     1297           
  Branches                 ?      215           
================================================
  Hits                     ?     1149           
  Misses                   ?      144           
  Partials                 ?        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@holaontiveros holaontiveros marked this pull request as draft February 13, 2026 18:25
@holaontiveros holaontiveros marked this pull request as ready for review February 13, 2026 18:30
Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't be against doing this is if makes things easier for migration (particularly for Tutor users), but a few questions first:

  • What is the impact on frontend-template-site?
  • Shouldn't we also change site.config.test.tsx?

@itsjeyd itsjeyd moved this from Needs Triage to In Eng Review in Contributions Feb 27, 2026
@itsjeyd itsjeyd added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Feb 27, 2026
@holaontiveros
Copy link
Author

I wouldn't be against doing this is if makes things easier for migration (particularly for Tutor users), but a few questions first:

  • What is the impact on frontend-template-site?
  • Shouldn't we also change site.config.test.tsx?

1.- None directly and may even be beneficial in case there was any route that could be clashing before
2.- We could, maybe we should for consistency, this only affects stuff that would directñly use those routes, so if no test depends on that then it just "works"

Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, please make the same change to site.config.test.tsx, then we can merge it.

I'm still not certain what's going to happen if somebody manually navigates to the root of a site and there are no routes there, but we can handle it separately.

@holaontiveros
Copy link
Author

Ok, please make the same change to site.config.test.tsx, then we can merge it.

I'm still not certain what's going to happen if somebody manually navigates to the root of a site and there are no routes there, but we can handle it separately.

It will be similar to what happens right now in the MFEs with all the routes when you either don't have a root thing or you miss a /

BUT in theory now we could have a catch all route for 404 maybe in frontend-base?

@arbrandes
Copy link
Contributor

Yeah, I think a catch-all in the shell is probably the way to go!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc.

Projects

Status: No status
Status: In Eng Review

Development

Successfully merging this pull request may close these issues.

4 participants