chore: update base route path to match old paths#797
chore: update base route path to match old paths#797holaontiveros wants to merge 2 commits intoopenedx:frontend-basefrom
Conversation
|
Thanks for the pull request, @holaontiveros! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## frontend-base #797 +/- ##
================================================
Coverage ? 88.58%
================================================
Files ? 158
Lines ? 1297
Branches ? 215
================================================
Hits ? 1149
Misses ? 144
Partials ? 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7979015 to
0cf411d
Compare
arbrandes
left a comment
There was a problem hiding this comment.
I wouldn't be against doing this is if makes things easier for migration (particularly for Tutor users), but a few questions first:
- What is the impact on frontend-template-site?
- Shouldn't we also change site.config.test.tsx?
1.- None directly and may even be beneficial in case there was any route that could be clashing before |
arbrandes
left a comment
There was a problem hiding this comment.
Ok, please make the same change to site.config.test.tsx, then we can merge it.
I'm still not certain what's going to happen if somebody manually navigates to the root of a site and there are no routes there, but we can handle it separately.
It will be similar to what happens right now in the MFEs with all the routes when you either don't have a root thing or you miss a BUT in theory now we could have a catch all route for 404 maybe in frontend-base? |
|
Yeah, I think a catch-all in the shell is probably the way to go! |
This will make the base route to match the old paths, which will alow to switch between MFE / frontendapps easily