Add Map - The Box PLUS#3465
Conversation
removed original thebox source image
changed map on thebox for april fools day
changed thebox to theboxplus for april fools
changed thebox to theboxplus for april fools
removed old thebox files
removed old thebox files
removed old thebox files
removed old thebox files
uploaded files for theboxplus
removed old thebox files
added files for theboxplus
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughRenamed the game map label from "The Box" to "The Box PLUS" in code and English translations, and reformatted coordinate arrays in the map manifest from single-line to multi-line entries (no numeric changes). Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
resources/maps/thebox/manifest.json (1)
1-124:⚠️ Potential issue | 🟡 MinorFix formatting to pass CI.
The pipeline reports code style issues. Run
npx prettier --write resources/maps/thebox/manifest.jsonto fix.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@resources/maps/thebox/manifest.json` around lines 1 - 124, The JSON manifest has formatting/style issues causing CI failures; run the code formatter to fix it by executing the project-preferred formatter (e.g., run "npx prettier --write resources/maps/thebox/manifest.json") or reformat the file so keys like "map", "map16x", "map4x", "name", and the "nations" array are properly indented and spaced to match the repository Prettier config, then stage and commit the updated manifest.json.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/core/game/Game.ts`:
- Line 125: The enum member TheBox was changed from "The Box" to "The Box PLUS",
which breaks deserialization; revert or add compatibility: update the Game enum
member TheBox in Game.ts back to the original "The Box" (or else add a stable
canonical value plus a legacy alias), and modify the Zod schemas GameConfig and
ServerPrestartMessageSchema in src/core/Schemas.ts to accept both values (use a
z.union or include the legacy literal) so existing saved games/replays and
network messages with "The Box" continue to parse; alternatively, if
intentional, add a clear migration path and documentation so deserializers can
map "The Box" → "The Box PLUS".
---
Outside diff comments:
In `@resources/maps/thebox/manifest.json`:
- Around line 1-124: The JSON manifest has formatting/style issues causing CI
failures; run the code formatter to fix it by executing the project-preferred
formatter (e.g., run "npx prettier --write resources/maps/thebox/manifest.json")
or reformat the file so keys like "map", "map16x", "map4x", "name", and the
"nations" array are properly indented and spaced to match the repository
Prettier config, then stage and commit the updated manifest.json.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: f5e7c7b9-5d06-4144-9d9f-f306b4f3ca8d
⛔ Files ignored due to path filters (4)
map-generator/assets/maps/thebox/image.pngis excluded by!**/*.pngresources/maps/thebox/map.binis excluded by!**/*.binresources/maps/thebox/map16x.binis excluded by!**/*.binresources/maps/thebox/map4x.binis excluded by!**/*.bin
📒 Files selected for processing (4)
resources/lang/en.jsonresources/maps/thebox/manifest.jsonresources/maps/thebox/thumbnail.webpsrc/core/game/Game.ts
| Passage = "Passage", | ||
| Sierpinski = "Sierpinski", | ||
| TheBox = "The Box", | ||
| TheBox = "The Box PLUS", |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Check if the enum value is used in serialization or stored configs
rg -n "The Box" --type=ts -C2Repository: openfrontio/OpenFrontIO
Length of output: 340
🏁 Script executed:
#!/bin/bash
# Check for any references to this map in test files or configs
rg -n "TheBox|thebox" --type=json -g '!**/lang/**' -g '!**/manifest.json'Repository: openfrontio/OpenFrontIO
Length of output: 131
🏁 Script executed:
#!/bin/bash
# Find the enum definition and how it's used
rg -n "enum.*GameMapType|TheBox" --type=ts -B2 -A10 | head -80Repository: openfrontio/OpenFrontIO
Length of output: 4025
🏁 Script executed:
#!/bin/bash
# Search for deserialization logic that might use the enum value
rg -n "deserialize|fromJSON|parse" --type=ts -A5 | grep -A5 -B5 "GameMapType\|TheBox" | head -80Repository: openfrontio/OpenFrontIO
Length of output: 49
🏁 Script executed:
#!/bin/bash
# Check if the enum value is directly compared or used for lookups
rg -n "\"The Box\"|'The Box'" --type=tsRepository: openfrontio/OpenFrontIO
Length of output: 49
🏁 Script executed:
#!/bin/bash
# Find where GameMapType enum is used for serialization
rg -n "GameMapType" --type=ts -B2 -A2 | head -100Repository: openfrontio/OpenFrontIO
Length of output: 5132
Breaking change: enum value affects deserialization.
Changing the enum value from "The Box" to "The Box PLUS" breaks backward compatibility. The Zod validation schemas in src/core/Schemas.ts (GameConfig, ServerPrestartMessageSchema) validate serialized values against enum values. Existing game configs and network messages with "The Box" will fail deserialization.
The filesystem path lookup still works (uses enum key TheBox → "thebox"), but any saved games, replays, or cross-version communication will break.
If this is temporary, document the breaking change clearly. Otherwise, implement a migration strategy.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@src/core/game/Game.ts` at line 125, The enum member TheBox was changed from
"The Box" to "The Box PLUS", which breaks deserialization; revert or add
compatibility: update the Game enum member TheBox in Game.ts back to the
original "The Box" (or else add a stable canonical value plus a legacy alias),
and modify the Zod schemas GameConfig and ServerPrestartMessageSchema in
src/core/Schemas.ts to accept both values (use a z.union or include the legacy
literal) so existing saved games/replays and network messages with "The Box"
continue to parse; alternatively, if intentional, add a clear migration path and
documentation so deserializers can map "The Box" → "The Box PLUS".
github-project-automation
bot
moved this from Triage
to Development
in OpenFront Release Management
github-project-automation
bot
moved this from Development
to Complete
in OpenFront Release Management
1 participant
Description:
Add map The Box PLUS. Huge improvements to The Box for April 1st! Now players can experience varied terrain while playing the brand new The Box PLUS!
##Discord username
PlaysBadly