Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
53 changes: 53 additions & 0 deletions map-generator/assets/maps/australiamediterran/info.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
{
"name": "Mediterran Sea in Australia",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Typo: "Mediterran" should be "Mediterranean".

Same spelling fix needed here for consistency with the corrected translation.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@map-generator/assets/maps/australiamediterran/info.json` at line 2, Fix the
typo in the JSON "name" value: change the string "Mediterran Sea in Australia"
to "Mediterranean Sea in Australia" (update the "name" property in info.json so
it matches the corrected translation and spelling).

"nations": [
{
"coordinates": [1277, 996],
"name": "South Australia",
"strength": 1,
"flag": "aus_souaus"
},
{
"coordinates": [805, 304],
"name": "Nothern Territory",
"strength": 1,
Comment on lines +11 to +13
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Typo: "Nothern" should be "Northern".

-      "name": "Nothern Territory",
+      "name": "Northern Territory",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"coordinates": [805, 304],
"name": "Nothern Territory",
"strength": 1,
"coordinates": [805, 304],
"name": "Northern Territory",
"strength": 1,
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@map-generator/assets/maps/australiamediterran/info.json` around lines 11 -
13, The "name" field value currently reads "Nothern Territory" and should be
corrected; locate the JSON object with "name": "Nothern Territory" in the map
info (the entry with "coordinates": [805, 304] and "strength": 1) and change the
"name" value to "Northern Territory" to fix the typo.

"flag": "aus_norter"
},
{
"coordinates": [406, 817],
"name": "Western Australia",
"strength": 1,
"flag": "aus_wesaus"
},
{
"coordinates": [1578, 1407],
"name": "Tasmania",
"strength": 2,
"flag": "aus_tas"
},
{
"coordinates": [992, 570],
"name": "Italy",
"strength": 2,
"flag": "it"
},
{
"coordinates": [1252, 595],
"name": "Greece",
"strength": 3,
"flag": "gr"
},
{
"coordinates": [1708, 745],
"name": "Cyprus",
"strength": 1,
"flag": "cy"
},
{
"coordinates": [255, 608],
"name": "Spain",
"strength": 2,
"flag": "es"
}
]
}
1 change: 1 addition & 0 deletions map-generator/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ var maps = []struct {
{Name: "africa"},
{Name: "asia"},
{Name: "australia"},
{Name: "australiamediterran"},
{Name: "achiran"},
{Name: "alps"},
{Name: "baikal"},
Expand Down
1 change: 1 addition & 0 deletions resources/lang/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -301,6 +301,7 @@
"britannia": "Britannia",
"gatewaytotheatlantic": "Gateway to the Atlantic",
"australia": "Australia",
"australiamediterran": "Mediterran Sea in Australia",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Typo: "Mediterran" should be "Mediterranean".

The map name is missing letters. "Mediterran Sea" → "Mediterranean Sea".

-    "australiamediterran": "Mediterran Sea in Australia",
+    "australiamediterran": "Mediterranean Sea in Australia",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"australiamediterran": "Mediterran Sea in Australia",
"australiamediterran": "Mediterranean Sea in Australia",
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@resources/lang/en.json` at line 304, Fix the typo in the translation entry:
change the value for the "australiamediterran" key from "Mediterran Sea in
Australia" to "Mediterranean Sea in Australia". If the key name
"australiamediterran" is used elsewhere or was intended to include the full
correct spelling, also rename the key to "australiamediterranean" and update any
references to that key throughout the codebase.

"random": "Random",
"iceland": "Iceland",
"pangaea": "Pangaea",
Expand Down
68 changes: 68 additions & 0 deletions resources/maps/australiamediterran/manifest.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,68 @@
{
"map": {
"height": 1500,
"num_land_tiles": 890500,
"width": 2000
},
"map16x": {
"height": 375,
"num_land_tiles": 53237,
"width": 500
},
"map4x": {
"height": 750,
"num_land_tiles": 219264,
"width": 1000
},
"name": "Mediterran Sea in Australia",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Typo: "Mediterran" should be "Mediterranean".

Same spelling fix needed here.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@resources/maps/australiamediterran/manifest.json` at line 17, Fix the
spelling in the manifest "name" field: update the value for the "name" property
(currently "Mediterran Sea in Australia") to the correct spelling "Mediterranean
Sea in Australia" so the manifest's name string is accurate.

"nations": [
{
"coordinates": [1277, 996],
"flag": "aus_souaus",
"name": "South Australia",
"strength": 1
},
{
"coordinates": [805, 304],
"flag": "aus_norter",
"name": "Nothern Territory",
"strength": 2
Comment on lines +25 to +29
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Typo: "Nothern" should be "Northern".

-      "name": "Nothern Territory",
+      "name": "Northern Territory",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
{
"coordinates": [805, 304],
"flag": "aus_norter",
"name": "Nothern Territory",
"strength": 2
{
"coordinates": [805, 304],
"flag": "aus_norter",
"name": "Northern Territory",
"strength": 2
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@resources/maps/australiamediterran/manifest.json` around lines 25 - 29, The
"name" value in the manifest entry is misspelled — change "Nothern Territory" to
"Northern Territory" in the JSON object (the entry with "coordinates": [805,
304], "flag": "aus_norter", "strength": 2) so the region name is correct; ensure
the change preserves valid JSON string formatting.

},
{
"coordinates": [406, 817],
"flag": "aus_wesaus",
"name": "Western Australia",
"strength": 1
},
{
"coordinates": [1578, 1407],
"flag": "aus_tas",
"name": "Tasmania",
"strength": 3
},
{
"coordinates": [992, 570],
"flag": "it",
"name": "Italy",
"strength": 2
},
{
"coordinates": [1252, 595],
"flag": "gr",
"name": "Greece",
"strength": 1
},
{
"coordinates": [1708, 745],
"flag": "cy",
"name": "Cyprus",
"strength": 1
},
{
"coordinates": [255, 608],
"flag": "es",
"name": "Spain",
"strength": 1
}
]
}
1 change: 1 addition & 0 deletions resources/maps/australiamediterran/map.bin

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions resources/maps/australiamediterran/map16x.bin

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions resources/maps/australiamediterran/map4x.bin

Large diffs are not rendered by default.

Binary file added resources/maps/australiamediterran/thumbnail.webp
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 2 additions & 0 deletions src/core/game/Game.ts
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ export enum GameMapType {
Britannia = "Britannia",
GatewayToTheAtlantic = "Gateway to the Atlantic",
Australia = "Australia",
Australiamediterran = "Mediterran Sea in Australia",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Same typo: "Mediterran" should be "Mediterranean".

-  Australiamediterran = "Mediterran Sea in Australia",
+  Australiamediterran = "Mediterranean Sea in Australia",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
Australiamediterran = "Mediterran Sea in Australia",
Australiamediterran = "Mediterranean Sea in Australia",
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/core/game/Game.ts` at line 101, The enum entry Australiamediterran
contains a misspelling in its string value; update the value from "Mediterran
Sea in Australia" to "Mediterranean Sea in Australia" for the
Australiamediterran enum/member in src/core/game/Game.ts and search for other
occurrences of "Mediterran" to correct any additional typos.

Iceland = "Iceland",
EastAsia = "East Asia",
BetweenTwoSeas = "Between Two Seas",
Expand Down Expand Up @@ -165,6 +166,7 @@ export const mapCategories: Record<string, GameMapType[]> = {
GameMapType.EastAsia,
GameMapType.Mena,
GameMapType.Australia,
GameMapType.Australiamediterran,
GameMapType.FaroeIslands,
GameMapType.FalklandIslands,
GameMapType.Baikal,
Expand Down
1 change: 1 addition & 0 deletions src/server/MapPlaylist.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ const frequency: Partial<Record<GameMapName, number>> = {
Africa: 7,
Asia: 6,
Australia: 4,
Australiamediterran: 8,
Achiran: 5,
Baikal: 5,
BetweenTwoSeas: 5,
Expand Down