8371722: java/net/httpclient/BufferSizePropertyClampTest.java should use Locale.ROOT

[dfuch]

The test verifies that the expected message is logged by the jdk.httpclient.HttpClient logger. However it fails when run in e.g. Polish Locale because it expects 16,384 and finds 16 384 (with a non breaking space).

The proposed change makes sure we use Locale.ROOT to format the message.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8371722: java/net/httpclient/BufferSizePropertyClampTest.java should use Locale.ROOT (Bug - P4)

Reviewers

• Daniel Jeliński (@djelinski - Reviewer)
• Jaikiran Pai (@jaikiran - Reviewer)
• Volkan Yazici (@vy - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28270/head:pull/28270
$ git checkout pull/28270

Update a local copy of the PR:
$ git checkout pull/28270
$ git pull https://git.openjdk.org/jdk.git pull/28270/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28270

View PR using the GUI difftool:
$ git pr show -t 28270

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28270.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dfuchs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dfuch This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8371722: java/net/httpclient/BufferSizePropertyClampTest.java should use Locale.ROOT

Reviewed-by: djelinski, jpai, vyazici

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

• 5f42c77: 8370839: Tests to verify peculiar Proxy dispatching behaviors
• b6ba1ac: 8371093: Assert "section header string table should be loaded" failed on debug VM
• 676e6fd: 8367292: VectorAPI: Optimize VectorMask.fromLong/toLong() for SVE
• ... and 18 more: https://git.openjdk.org/jdk/compare/cbd77fc9f3e6c8f1e996b30afe208c6a074cce3a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@dfuch The following label will be automatically applied to this pull request:

• net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (e2f803fe)
• 00: Full (2c9acb4b)

[djelinski]

I verified that this fixed the test failures on my Windows machine.

[dfuch]

Thanks for the reviews!

[dfuch]

/integrate

[openjdk]

Going to push as commit 48c59fa.
Since your change was applied there have been 28 commits pushed to the master branch:

• 9d6a61f: 8371558: C2: Missing optimization opportunity in AbsNode::Ideal
• 10220ed: 8367013: Add Atomic to package/replace idiom of volatile var plus AtomicAccess:: operations
• 795ec5c: 8370333: hotspot-unit-tests.md specifies wrong directory structure for tests
• ... and 25 more: https://git.openjdk.org/jdk/compare/cbd77fc9f3e6c8f1e996b30afe208c6a074cce3a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dfuch Pushed as commit 48c59fa.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.