Skip to content

Conversation

@RogerRiggs
Copy link
Contributor

@RogerRiggs RogerRiggs commented Nov 12, 2025

Redo change (8371732) that failed when the updated class objects were incompatible.
The fields of classes are changed to allow a more compact form of storage.

To ensure compatibility of the class objects, the fields are explicitly declared in SerialPersistentFields with the original field types.
The fields are marked transient to indicate the field declarations are not used for serialization.
The affected classes are java.time.LocalDate, MonthDay, and YearMonth.
Tests are added to verify the types and names of serialized fields of each class.

HijrahDate only changes the field types, the fields are transient and there is no change to the serialized from of the HijrahDate.class object.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires a CSR request matching fixVersion 26 to be approved (needs to be created)

Issue

  • JDK-8371732: [redo] Change java.time month/day field types to 'byte' (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28274/head:pull/28274
$ git checkout pull/28274

Update a local copy of the PR:
$ git checkout pull/28274
$ git pull https://git.openjdk.org/jdk.git pull/28274/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28274

View PR using the GUI difftool:
$ git pr show -t 28274

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28274.diff

Using Webrev

Link to Webrev Comment

…p size.

Explicitly declare SerialPersistentFields with the original field types to ensure
compatibility of the class objects. Also make fields transient to reinforce the point.
Affect classes are java.time.LocalDate, MonthDay, YearMonth, and HijrahDate.
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 12, 2025

👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 12, 2025

@RogerRiggs This change is no longer ready for integration - check the PR body for details.

@openjdk
Copy link

openjdk bot commented Nov 12, 2025

@RogerRiggs The following labels will be automatically applied to this pull request:

  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 12, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 12, 2025

Webrevs

@RogerRiggs
Copy link
Contributor Author

/label remove i18n

@openjdk
Copy link

openjdk bot commented Nov 12, 2025

@RogerRiggs
The i18n label was successfully removed.

Copy link
Contributor

@AlanBateman AlanBateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 12, 2025
@jddarcy
Copy link
Member

jddarcy commented Nov 12, 2025

/csr needed

@openjdk openjdk bot added the csr Pull request needs approved CSR before integration label Nov 12, 2025
@openjdk
Copy link

openjdk bot commented Nov 12, 2025

@jddarcy has indicated that a compatibility and specification (CSR) request is needed for this pull request.

@RogerRiggs please create a CSR request for issue JDK-8371732 with the correct fix version. This pull request cannot be integrated until the CSR request is approved.

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs [email protected] csr Pull request needs approved CSR before integration rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

3 participants