8371769: TestMemoryInvisibleParent.java fails java.nio.file.AccessDeniedException #28286
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
Test test/hotspot/jtreg/containers/docker/TestMemoryInvisibleParent.java fails when run with non-root user. Test will try to write file /sys/fs/cgroup/memory/hidden-parent-TestMemoryInvisibleParent26/memory.limit_in_bytes, and this will make non-root user report java.nio.file.AccessDeniedException. So I think we should skip this test when user is not root.
This PR also add prefix indent for a try block, but do not touch the original logic.
Change has been verified locally on linux-aarch64 with non-root user.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28286/head:pull/28286$ git checkout pull/28286Update a local copy of the PR:
$ git checkout pull/28286$ git pull https://git.openjdk.org/jdk.git pull/28286/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28286View PR using the GUI difftool:
$ git pr show -t 28286Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28286.diff
Using Webrev
Link to Webrev Comment