-
Notifications
You must be signed in to change notification settings - Fork 48
(feat) O3-5005 add search tab to dispensing home page #489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Size Change: -42.1 kB (-4.16%) Total Size: 970 kB
ℹ️ View Unchanged
|
<h5>Search for a patient</h5> | ||
<div>Search for a patient by name or identifier number</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you forgot to include the translation strings for these
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM, though we do need to add the translations @pirupius pointed out.
I didn't see the location filter in the screenshot... is that going away?
Thanks @chibongho, LGTM This might be slightly beyond the scope of this PR, but could we consider using a stateful URL for filtering Search, Active Prescription, and All Prescription? For example, if we had a URL like:
it would filter prescriptions for that patient across all tabs. The main purpose is to integrate better with queues — when a patient is queued for pharmacy, the pharmacist shouldn’t need to search again to view their active prescriptions. |
@donaldkibet I think that's a good feature. It probably should be its own ticket, and have some design discussion around:
|
Requirements
Summary
This PR adds a search tab in the dispensing home page. Functionally, this tab is really similar to the "Active prescription" tab. The only difference is that it does not initiate request for data until the user searches for user.
Other changes:
Marking this as draft as I'm using a placeholder icon in lieu of the real search icon in pending PR openmrs/openmrs-esm-core#1454. Code-wise, this is ready for review.
Screenshots
See video. Note that patient "Manu" is searched twice, once via pressing the "Enter" key and once by clicking on the "Search" button.
OpenMRS.Mozilla.Firefox.2025-09-15.16-43-51.mp4
Related Issue
https://openmrs.atlassian.net/browse/O3-5005
Other