-
Notifications
You must be signed in to change notification settings - Fork 113
O3-3875: Fix JSON schema editor error indicators not showing #986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
RajPrakash681
wants to merge
9
commits into
openmrs:main
Choose a base branch
from
RajPrakash681:O3-3875-fix-json-editor-error-indicators-clean
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
O3-3875: Fix JSON schema editor error indicators not showing #986
RajPrakash681
wants to merge
9
commits into
openmrs:main
from
RajPrakash681:O3-3875-fix-json-editor-error-indicators-clean
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@NethmiRodrigo i have tried to fix this also please have a look. |
4 tasks
Contributor
Author
Contributor
Author
|
@denniskigen sir can you please review this also or tag anyone who can review this |
Contributor
Author
|
@NethmiRodrigo please have a look at this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes O3-3875 - JSON editor in form builder does not show error indicator in deployed environments (dev3, test3, o3 demo).
Problem
The JSON schema editor was not displaying error indicators (red X icons in the gutter and error markers) in production deployments, though it worked correctly in local development. This was due to:
ace-builds/webpack-resolverrelies on dynamic imports that don't work in production buildsSolution
webpack-resolverwith explicit static imports formode-jsonandtheme-textmateto ensure assets are bundled correctlyannotationsstate and generation logic to display error icons in the editor gutterChanges
src/components/schema-editor/schema-editor.component.tsx:ace-builds/webpack-resolverwith static importsannotationsstate managementerrorAnnotationsgeneration logicannotationsprop toAceEditorcomponentTesting
Tested locally with invalid JSON schemas - error indicators now show correctly. This fix ensures the same functionality works in production builds.
Screenshots
N/A - Visual changes are the same as local development (error indicators in gutter and line highlighting)