Draft
Conversation
Merge between changes in different PCs
…e/qick_internal into 5_organize_the_fw_dir
… testing the xcom
…PR-6-xcom_development
lharnaldi
added
firmware
meeg
reviewed
Jul 3, 2025
ghost
changed the title
ghost
marked this pull request as draft
|
I don't like that most of the commits included in the PR are not related to the XCOM, they are from different developments but will all be included in the project history. How can we clean this up? Or maybe Squash the merge so it is only shown as 1 commit? |
…se in the print_status function
|
@lharnaldi let's also include some of your test notebooks with this PR so there's some example to know how to use the IP |
Contributor
Author
|
Yes, you are right @dmartin2-fnal , these should be here also. I'll upload that. |
…e/qick into PR-6-xcom_development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The xcom driver and the source files are added.