Skip to content

Conversation

@chinacat567
Copy link
Contributor

@chinacat567 chinacat567 commented May 16, 2025

Background

  • In order to pseudonymize on ADIT client, a custom GET parameter was required to the dicomweb resut
  • These were added to dicomweb-client earlier

Description

  • Parse the additional parameter in the GET request in dicomweb/view.py
  • Validate the pseudonym (no backslashes, control chars, wildcards and <= 64 chars)
  • Pass this along to wadors_utils
  • Perform pseudonymization

Testing

  • Added tests for retrieve_study, retrieve_study_metadata , retrieve_series, retrieve_series_metadata, retrieve_image, retrieve_image_metadata to check for the pseudonymization

@chinacat567 chinacat567 added the enhancement New feature or request label May 19, 2025
@chinacat567 chinacat567 added this to ADIT May 19, 2025
@chinacat567 chinacat567 marked this pull request as ready for review May 19, 2025 14:00
@chinacat567 chinacat567 marked this pull request as draft May 19, 2025 14:24
@chinacat567 chinacat567 marked this pull request as ready for review May 20, 2025 08:08
@chinacat567 chinacat567 marked this pull request as draft May 21, 2025 09:28
@chinacat567 chinacat567 marked this pull request as ready for review May 25, 2025 15:45
@chinacat567 chinacat567 requested a review from medihack May 25, 2025 15:46
@chinacat567 chinacat567 marked this pull request as draft May 27, 2025 13:20
@chinacat567 chinacat567 marked this pull request as ready for review May 27, 2025 13:27
@medihack medihack merged commit 3188f16 into main May 27, 2025
1 check passed
@medihack medihack deleted the adit-pseudonym branch May 27, 2025 15:16
@github-project-automation github-project-automation bot moved this to Done in ADIT May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants