Skip to content

Conversation

@alonbg
Copy link

@alonbg alonbg commented Sep 12, 2016

+tests

@alonbg alonbg force-pushed the bind branch 3 times, most recently from a9d58cb to f2a1329 Compare September 14, 2016 15:17
@alonbg
Copy link
Author

alonbg commented Sep 14, 2016

Hi @agentzh
Some tests keep failing although all tests pass on my local.
Please advise (maybe on a better way to write them :). Thanks!

@alonbg alonbg force-pushed the bind branch 2 times, most recently from 9402927 to a4f14f9 Compare September 18, 2016 08:36
@bjne
Copy link

bjne commented Oct 25, 2016

What is the status here? Nice effort, but code does not build.

@alonbg
Copy link
Author

alonbg commented Nov 1, 2016

@agentzh you suggested having ip_transparent in the setoption api. I'm really not sure this is the way to go since there is a dependency between ip_transparent and bind. As in proxy_bind address [transparent] | off; directive which sets sets pc-local which in turn is a condition for checking pc->transparent value. In other words, binding to a local address is a mandatory condition for setting the ip_transparent socket option.
Maybe also in our case transparent should be a bind() option instead of a separate api.
What do you think ?

@splitice
Copy link

splitice commented Nov 1, 2016

I tend to agree with @alonbg, its closer to the nginx semantics too which is appealing to me.

@zhuizhuhaomeng zhuizhuhaomeng changed the title UDP/TCP Bind feature: add support for tcp/udp bind. Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants