[Explore Vis]Feat/add bar gauge #10697
Merged
+1,722
−77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opensearch-changeset-bot bot
added a commit
to Qxisylolo/OpenSearch-Dashboards
that referenced
this pull request
Oct 9, 2025
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #10697 +/- ##
==========================================
+ Coverage 60.49% 60.52% +0.03%
==========================================
Files 4506 4511 +5
Lines 121106 121296 +190
Branches 20174 20234 +60
==========================================
+ Hits 73262 73420 +158
- Misses 42722 42732 +10
- Partials 5122 5144 +22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Qxisylolo
requested review from
AMoo-Miki,
BionIT,
Flyingliuhub,
LDrago27,
Maosaic,
SuZhou-Joe,
ZilongX,
abbyhu2000,
ananzh,
angle943,
ashwin-pc,
bandinib-amzn,
curq,
huyaboo,
joshuali925,
joshuarrrr,
kavilla,
manasvinibs,
mengweieric,
ruanyl,
sejli,
virajsanghvi,
xinruiba,
zengyan-amazon,
zhongnansu and
zhyuanqi
as code owners
Hailong-am
reviewed
Oct 22, 2025
.../explore/public/components/visualizations/bar_gauge/bar_gauge_exclusive_vis_options.test.tsx
Outdated
Show resolved
Hide resolved
Hailong-am
reviewed
Oct 22, 2025
| hex = '#' + hex[1] + hex[1] + hex[2] + hex[2] + hex[3] + hex[3]; | ||
| } | ||
|
|
||
| let r = parseInt(hex.slice(1, 3), 16); |
There was a problem hiding this comment.
nit: would better have a check for hex to make sure it's vaild
| return result; | ||
| }; | ||
|
|
||
| export const NormalizeData = (data: number, start: number, end: number) => { |
Qxisylolo
force-pushed
the
feat/add_bar_gauge
branch
from
f41d42b to
6aa3315
Compare
Hailong-am
previously approved these changes
Oct 24, 2025
ruanyl
previously approved these changes
Oct 24, 2025
| ? { | ||
| id: 'horizontal', | ||
| label: i18n.translate( | ||
| 'explore.vis.barGauge.orientation.threshold.horizontal.isXaxisNumerical', |
There was a problem hiding this comment.
isXaxisNumerical this key seems incorrect
| isXaxisNumerical | ||
| ? { | ||
| id: 'vertical', | ||
| label: i18n.translate('explore.vis.barGauge.orientation.vertical.isXaxisNumerical', { |
There was a problem hiding this comment.
isXaxisNumerical this key seems incorrect, should be orientation.vertical?
| { offset: 0, color: thresholds[0].color }, | ||
| { | ||
| offset: 1, | ||
| color: darkenColor(thresholds[0]?.color, 2), |
There was a problem hiding this comment.
I think we don't need to darken the color, just use thresholds[0].color in this case
Qxisylolo
force-pushed
the
feat/add_bar_gauge
branch
from
32d2f1e to
6fe849c
Compare
Signed-off-by: Qxisylolo <[email protected]>
Signed-off-by: Qxisylolo <[email protected]>
Signed-off-by: Qxisylolo <[email protected]>
Signed-off-by: Qxisylolo <[email protected]>
Signed-off-by: Qxisylolo <[email protected]>
Signed-off-by: Qxisylolo <[email protected]>
Signed-off-by: Qxisylolo <[email protected]>
Signed-off-by: Qxisylolo <[email protected]>
Signed-off-by: Qxisylolo <[email protected]>
Signed-off-by: Qxisylolo <[email protected]>
Signed-off-by: Qxisylolo <[email protected]>
Signed-off-by: Qxisylolo <[email protected]>
Signed-off-by: Qxisylolo <[email protected]>
Signed-off-by: Qxisylolo <[email protected]>
Signed-off-by: Qxisylolo <[email protected]>
Signed-off-by: Qxisylolo <[email protected]>
Signed-off-by: Qxisylolo <[email protected]>
Qxisylolo
force-pushed
the
feat/add_bar_gauge
branch
from
0433818 to
fea707f
Compare
ruanyl
approved these changes
Oct 27, 2025
Hailong-am
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this pr adds bar gauge
Screenshot
2025-10-14.15.59.38.mov
2025-10-14.17.19.17.mov
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration