Skip to content

Conversation

@Qxisylolo
Copy link
Contributor

Description

this pr fixes Incorrect bucket options displayed

Screenshot

before:
截屏2025-10-14 18 17 36

after:
截屏2025-10-14 18 13 51

Testing the changes

Changelog

  • fix: Incorrect bucket options displayed

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Qxisylolo <[email protected]>
@codecov
Copy link

codecov bot commented Oct 14, 2025

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 60.34%. Comparing base (67890d6) to head (de5d525).
⚠️ Report is 63 commits behind head on main.

Files with missing lines Patch % Lines
.../components/visualizations/bar/bar_vis_options.tsx 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10718      +/-   ##
==========================================
+ Coverage   60.18%   60.34%   +0.15%     
==========================================
  Files        4428     4462      +34     
  Lines      118504   119484     +980     
  Branches    19456    19746     +290     
==========================================
+ Hits        71320    72099     +779     
- Misses      42265    42382     +117     
- Partials     4919     5003      +84     
Flag Coverage Δ
Linux_1 26.58% <ø> (-0.07%) ⬇️
Linux_2 38.82% <ø> (-0.01%) ⬇️
Linux_3 38.89% <ø> (+0.18%) ⬆️
Linux_4 33.00% <85.71%> (?)
Windows_1 26.60% <ø> (-0.07%) ⬇️
Windows_2 38.79% <ø> (-0.01%) ⬇️
Windows_3 38.90% <ø> (+0.18%) ⬆️
Windows_4 33.00% <85.71%> (+0.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Qxisylolo <[email protected]>
@ruanyl ruanyl merged commit 46060ab into opensearch-project:main Oct 20, 2025
82 checks passed
paulstn pushed a commit to paulstn/OpenSearch-Dashboards that referenced this pull request Oct 20, 2025
…ect#10718)

* fix

Signed-off-by: Qxisylolo <[email protected]>

* Changeset file for PR opensearch-project#10718 created/updated

* add comments

Signed-off-by: Qxisylolo <[email protected]>

---------

Signed-off-by: Qxisylolo <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants