-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Query cancel for new discover #10727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Ruchi Sharma <[email protected]>
Signed-off-by: Ruchi Sharma <[email protected]>
Signed-off-by: Ruchi Sharma <[email protected]>
Signed-off-by: Ruchi Sharma <[email protected]>
Signed-off-by: Ruchi Sharma <[email protected]>
Signed-off-by: Ruchi Sharma <[email protected]>
Signed-off-by: Ruchi Sharma <[email protected]>
| # @experimental Set the value to true to enable context provider | ||
| # contextProvider: | ||
| # enabled: true | ||
| # enabled: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this included by mistake?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure why it's showing up, though i didn't make any changes, tried to reset but still shows up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can do:
git restore --staged config/opensearch_dashboatrds.yml
before commiting.
And better yet, something we learned from @ashwin-pc , if you have temporaryopensearch_dashboards.yml changes you need to make, create a opensearch_dashboards.dev.yml within this folder and have your personal changes in there. Then you never have to interact with the opensearch_dashboards.yml file. This is what mine looks like:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and i believe its showing up because you prob made changes to this file for your local configs, and your IDE is auto-formatting it.
TBH its more proper to add the extra whitespace like your change does, but ideally in the future its best to leave this file out of the diff to make it easier for reviewers.
You can use vim to undo this change if you really wanted and commit it, but not a blocker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks justin that would help
|
Can you rename PR tittle? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when i first load the page (ie refresh), i don't see the cancel button. Could we update the logic to have the cancel there too?
Signed-off-by: Ruchi Sharma <[email protected]>
src/plugins/explore/public/components/top_nav/query_execution_button/query_execution_button.tsx
Show resolved
Hide resolved
Signed-off-by: Ruchi Sharma <[email protected]>
Signed-off-by: Ruchi Sharma <[email protected]>
in case of initial load, I deliberately put it on timefilter update, not on load I would implement for initial load too, if this looks blocker to you. Let me know |
Signed-off-by: Ruchi Sharma <[email protected]>
Signed-off-by: Ruchi Sharma <[email protected]>
Add newline at the end of the file for consistency. Signed-off-by: Ruchi Sharma <[email protected]>
Signed-off-by: Ruchi Sharma <[email protected]>
Signed-off-by: Ruchi Sharma <[email protected]>
Signed-off-by: Ruchi Sharma <[email protected]>
Signed-off-by: Ruchi Sharma <[email protected]>
Signed-off-by: Ruchi Sharma <[email protected]>
Signed-off-by: Ruchi Sharma <[email protected]>
Signed-off-by: Ruchi Sharma <[email protected]>
Signed-off-by: Ruchi Sharma <[email protected]>
Signed-off-by: Ruchi Sharma <[email protected]>
Signed-off-by: Ruchi Sharma <[email protected]>
Signed-off-by: Ruchi Sharma <[email protected]>
Description
Summary
This PR implements a comprehensive cancel button feature for query execution across OpenSearch Dashboards, allowing users to cancel running
queries in both the standard QueryEditor and custom QueryExecutionButton scenarios.
The implementation provides a unified cancel button
experience that works consistently across different data source types (OpenSearch and S3).
What Changed
Core Features
Screenshot
Screen.Recording.2025-10-15.at.3.52.17.PM.mov
Changelog
Check List
yarn test:jestyarn test:jest_integration