Skip to content

Conversation

@angle943
Copy link
Collaborator

Description

Issues Resolved

Screenshot

Testing the changes

Changelog

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Justin Kim <[email protected]>
@github-actions
Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

@codecov
Copy link

codecov bot commented Oct 15, 2025

Codecov Report

❌ Patch coverage is 60.90226% with 52 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.33%. Comparing base (9850413) to head (a2ad97d).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
..._dataset/reconcile_visible_columns_with_dataset.ts 15.38% 11 Missing ⚠️
..._or_time_to_fields/add_source_or_time_to_fields.ts 15.38% 11 Missing ⚠️
...t/utils/get_default_columns/get_default_columns.ts 35.71% 9 Missing ⚠️
...add_visible_column_name/add_visible_column_name.ts 14.28% 6 Missing ⚠️
..._visible_column_name/remove_visible_column_name.ts 14.28% 6 Missing ⚠️
.../utils/state_management/utils/redux_persistence.ts 70.00% 3 Missing ⚠️
...ublic/components/data_table/explore_data_table.tsx 33.33% 2 Missing ⚠️
...mponents/fields_selector/fields_selector_panel.tsx 33.33% 2 Missing ⚠️
...results_table/hooks/use_rows_data/use_rows_data.ts 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10732      +/-   ##
==========================================
- Coverage   60.34%   60.33%   -0.02%     
==========================================
  Files        4462     4473      +11     
  Lines      119495   119679     +184     
  Branches    19748    19782      +34     
==========================================
+ Hits        72109    72206      +97     
- Misses      42383    42465      +82     
- Partials     5003     5008       +5     
Flag Coverage Δ
Linux_1 26.58% <ø> (ø)
Linux_2 38.82% <ø> (ø)
Linux_3 38.89% <ø> (+<0.01%) ⬆️
Linux_4 ?
Windows_1 26.60% <ø> (ø)
Windows_2 38.79% <ø> (ø)
Windows_3 38.90% <ø> (ø)
Windows_4 33.06% <60.90%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant