-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Pass 5 rows as context if no row is expanded #10743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
… logic Signed-off-by: Megha Goyal <[email protected]>
Signed-off-by: Megha Goyal <[email protected]>
Signed-off-by: Megha Goyal <[email protected]>
Signed-off-by: Megha Goyal <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10743 +/- ##
==========================================
- Coverage 60.46% 60.46% -0.01%
==========================================
Files 4483 4483
Lines 120056 120141 +85
Branches 19879 19895 +16
==========================================
+ Hits 72595 72643 +48
- Misses 42424 42452 +28
- Partials 5037 5046 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ToolExecutor Signed-off-by: Megha Goyal <[email protected]>
I don;t think we should pass default rows. It might confuse future dynamic expanded rows. For example, if I expand several rows after explore loaded, how could I separate default rows and user expanded rows? If we need fields to improve explore context, we could modify page context to pass fields and fields mapping. |
@ananzh thanks for the review. If you notice, these are only passed when no row is expanded. Further, I am also exploring how to modify the system prompt to use field mappings directly by the LLM. I would suggest to merge this for now, as this helps in improving the accuracy of the agent dramatically. Another area I'm exploring is how to manage this context effectively. Few ideas are showing the context usage in the evals, logging them for easier debugging, etc. I don't think it'll be a single shot answer, because we need to be mindful of the context window here. Let me know what you think. |
Description
Issues Resolved
NA
Screenshot
Testing the changes
Tested against Langgraph agent.
Changelog
Check List
yarn test:jest
yarn test:jest_integration