Trace:Details Follow up to pr10745 and additional bug fixes.

[yanatha99]

Description

Follow up items to #10745 (comment) and additional bug fixes

1. Change SpanStatusFilter from multi-select to single-select
2. Render SpanStatusFilter as FC
3. Remove empty function passed to setSpanFiltersWithStorage and add non-null assertion
4. Remove isSpanOk function, just directly use !isSpanError
5. Add new lines for styling on copy icon
6. Simplify SpanHierarchyTable height to just change based on whether it's rendered in flyout or on trace details page
7. Fix trace view filter padding (Discussed with @TackAdam)

Screenshot

Testing the changes

1. Open trace detail flyout for any trace by clicking timestamp in trace table
2. The height of table in 'Timeline' tab view of flyout should be consistent
3. Open the Trace details page
4. The height of table in 'Timeline' tab view on page should be consistent
5. Click the "Filter by status" button to open status filter popover
6. Click any status filter and verify the filter has been applied to the spans displayed
7. Click a different status filter and verify the previous status filter has been removed and new filter applied to the spans displayed

Changelog

• fix: Follow up to pr10745 and additional bug fixes.

Check List

• All tests pass
  • yarn test:jest
  • yarn test:jest_integration
• New functionality includes testing.
• New functionality has been documented.
• Update CHANGELOG.md
• Commits are signed per the DCO using --signoff

[codecov]

Codecov Report

❌ Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.52%. Comparing base (3848a76) to head (fc4207a).
⚠️ Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
...traces/span_detail_tables/span_hierarchy_table.tsx	87.50%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #10778      +/-   ##
==========================================
- Coverage   60.53%   60.52%   -0.01%     
==========================================
  Files        4486     4486              
  Lines      120223   120213      -10     
  Branches    19925    19924       -1     
==========================================
- Hits        72772    72761      -11     
+ Misses      42410    42408       -2     
- Partials     5041     5044       +3     

Flag	Coverage Δ
Linux_1	26.58% <ø> (ø)
Linux_2	38.82% <ø> (ø)
Linux_3	39.09% <ø> (ø)
Linux_4	33.30% <88.88%> (-0.01%)	⬇️
Windows_1	26.59% <ø> (ø)
Windows_2	38.79% <ø> (ø)
Windows_3	39.10% <ø> (+<0.01%)	⬆️
Windows_4	33.30% <88.88%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[earthling-shruti]

Do we not need the recursion for any use case?

[yanatha99]

gatherAllSpanIds replaced by simpler new Set(filteredSpans.map((span) => span.spanId)). The recursive function went through the hierarchical span list to get all spanId's, while this new approach is simpler by just going through the filtered span list to get all spanId's. The hierarchical span list is built from the filtered span list anyways.