test(cypress) add tests for gauge and bar gauge #10894
Merged
+211
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opensearch-changeset-bot bot
added a commit
to Qxisylolo/OpenSearch-Dashboards
that referenced
this pull request
Nov 10, 2025
Qxisylolo
changed the title
Qxisylolo
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10894 +/- ##
=======================================
Coverage 60.76% 60.76%
=======================================
Files 4533 4533
Lines 122129 122129
Branches 20461 20461
=======================================
Hits 74207 74207
Misses 42689 42689
Partials 5233 5233
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Qxisylolo
requested review from
AMoo-Miki,
BionIT,
Flyingliuhub,
LDrago27,
SuZhou-Joe,
ZilongX,
abbyhu2000,
ananzh,
ashwin-pc,
bandinib-amzn,
curq,
huyaboo,
joshuali925,
joshuarrrr,
kavilla,
manasvinibs,
mengweieric,
ruanyl,
sejli,
virajsanghvi,
xinruiba,
zengyan-amazon,
zhongnansu and
zhyuanqi
as code owners
Qxisylolo
requested review from
Maosaic,
TackAdam,
angle943,
d-buckner,
paulstn,
ps48,
raintygao,
ruchidh,
sumukhswamy and
wanglam
as code owners
xluo-aws
approved these changes
Nov 10, 2025
ruanyl
reviewed
Nov 10, 2025
cypress/utils/commands.explore.js
Outdated
| .within(() => { | ||
| cy.getElementByTestId('exploreChartTypeSelector').should('be.visible').click(); | ||
| }); | ||
| cy.getElementByTestId(`exploreChartTypeSelector-${options.type}`).should('be.visible').click(); |
Member
There was a problem hiding this comment.
Do you need to change all places that uses createVisualizationWithQuery to pass options.type? Like Pie and Area. Why not just use chartType as before?
Contributor
Author
There was a problem hiding this comment.
yes, pie and area is already updated
Signed-off-by: Qxisylolo <[email protected]>
Signed-off-by: Qxisylolo <[email protected]>
Signed-off-by: Qxisylolo <[email protected]>
Qxisylolo
force-pushed
the
feat/add_tests_bargauge_gauge
branch
from
9b53fbd to
de92f5b
Compare
ruanyl
approved these changes
Nov 11, 2025
wanglam
approved these changes
Nov 11, 2025
SuZhou-Joe
approved these changes
Nov 11, 2025
lunalzm
pushed a commit
to lunalzm/OpenSearch-Dashboards
that referenced
this pull request
Nov 11, 2025
…0894) * add tests for gauge and bar gauge Signed-off-by: Qxisylolo <[email protected]> --------- Signed-off-by: Qxisylolo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Yulong Ruan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration