Fix first character being trimmed during Query Snippet Insertion #10901
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently there is an issue while inserting the first query snippet suggestion, the first character was being truncated.
Previously we used to computed what was the difference between the suggestion and typed word and using only the difference to insert the suggestion. However this had an issue when we were starting a query initially the replace range wasn't correct, this caused the first character to be truncated.
In this change instead of doing the above we are doing a token based comparison for insertText, where we skip all the fully matching tokens and only insert the partially matching and non matching tokens.
Issues Resolved
Screenshot
Testing the changes
Meeting+Recording+-+Sahoo.+Suchit+Instant+Meeting.38.mp4
Changelog
Check List
yarn test:jestyarn test:jest_integration