Skip to content

Conversation

@LDrago27
Copy link
Collaborator

Description

Remove onType PPL Formatter

Issues Resolved

Screenshot

Testing the changes

Meeting+Recording+-+Sahoo.+Suchit+Instant+Meeting.39.mp4

Changelog

  • fix: Remove onType PPL Formatter

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Suchit Sahoo <[email protected]>
@LDrago27 LDrago27 added OSD Changes being merged by the OSD team and removed distinguished-contributor labels Nov 11, 2025
@codecov
Copy link

codecov bot commented Nov 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.76%. Comparing base (b9341e5) to head (41b6a48).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10902   +/-   ##
=======================================
  Coverage   60.76%   60.76%           
=======================================
  Files        4533     4533           
  Lines      122164   122159    -5     
  Branches    20471    20471           
=======================================
- Hits        74232    74229    -3     
+ Misses      42695    42692    -3     
- Partials     5237     5238    +1     
Flag Coverage Δ
Linux_1 26.57% <ø> (ø)
Linux_2 38.92% <ø> (+<0.01%) ⬆️
Linux_3 39.43% <ø> (-0.01%) ⬇️
Linux_4 33.75% <ø> (ø)
Windows_1 26.58% <ø> (ø)
Windows_2 38.90% <ø> (+<0.01%) ⬆️
Windows_3 39.43% <ø> (-0.01%) ⬇️
Windows_4 33.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@paulstn paulstn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there more details you can give on why we are removing the onTypeFormatter?

@LDrago27
Copy link
Collaborator Author

Are there more details you can give on why we are removing the onTypeFormatter?

@paulstn
When user is typing in a query and they press | the Autoformatter formats the query. Moving the cursor to next line (as expected). However we received feedback that this experience was a bit jarring and broke the overall user flow. Therefore this feature is being removed.

At the same time, user can always utilize the keyboard shortcut of (Shift + Ctrl + F) to manually trigger the formatter, to format the query .

@LDrago27 LDrago27 removed the OSD Changes being merged by the OSD team label Nov 11, 2025
@LDrago27 LDrago27 merged commit e37a40a into opensearch-project:main Nov 11, 2025
80 of 81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants