-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Remove onType PPL Formatter #10902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove onType PPL Formatter #10902
Conversation
Signed-off-by: Suchit Sahoo <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10902 +/- ##
=======================================
Coverage 60.76% 60.76%
=======================================
Files 4533 4533
Lines 122164 122159 -5
Branches 20471 20471
=======================================
- Hits 74232 74229 -3
+ Misses 42695 42692 -3
- Partials 5237 5238 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
paulstn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there more details you can give on why we are removing the onTypeFormatter?
@paulstn At the same time, user can always utilize the keyboard shortcut of (Shift + Ctrl + F) to manually trigger the formatter, to format the query . |
Description
Remove onType PPL Formatter
Issues Resolved
Screenshot
Testing the changes
Meeting+Recording+-+Sahoo.+Suchit+Instant+Meeting.39.mp4
Changelog
Check List
yarn test:jestyarn test:jest_integration