Skip to content

Conversation

@Qxisylolo
Copy link
Contributor

Description

this pr is a small fix to make proper assertion to check if chart is correctly selected.

Issues Resolved

Screenshot

Testing the changes

Changelog

  • skip

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Qxisylolo <[email protected]>
@github-actions github-actions bot added distinguished-contributor Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry labels Nov 12, 2025
@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.75%. Comparing base (06a1ba8) to head (b5468c3).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10905   +/-   ##
=======================================
  Coverage   60.75%   60.75%           
=======================================
  Files        4533     4533           
  Lines      122206   122206           
  Branches    20481    20481           
=======================================
+ Hits        74246    74247    +1     
  Misses      42719    42719           
+ Partials     5241     5240    -1     
Flag Coverage Δ
Linux_1 26.57% <ø> (ø)
Linux_2 38.92% <ø> (ø)
Linux_3 39.44% <ø> (+<0.01%) ⬆️
Linux_4 33.74% <ø> (ø)
Windows_1 26.58% <ø> (ø)
Windows_2 38.90% <ø> (ø)
Windows_3 39.44% <ø> (+<0.01%) ⬆️
Windows_4 33.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Qxisylolo
Copy link
Contributor Author

flaky failure for table

截屏2025-11-12 15 44 12

@ruanyl ruanyl changed the title test(cypress)small fix for explore vis test(cypress): fix table vis tests to use the correct selector Nov 13, 2025
@ruanyl ruanyl merged commit 889338b into opensearch-project:main Nov 13, 2025
125 of 129 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

distinguished-contributor Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants