-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[Workspace] Trim collaboratorId when adding collaborators for workspace #10908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Binlong Gao <[email protected]>
ℹ️ Manual Changeset Creation ReminderPlease ensure manual commit for changeset file 10908.yml under folder changelogs/fragments to complete this PR. If you want to use the available OpenSearch Changeset Bot App to avoid manual creation of changeset file you can install it in your forked repository following this link. For more information about formatting of changeset files, please visit OpenSearch Auto Changeset and Release Notes Tool. |
Signed-off-by: Binlong Gao <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10908 +/- ##
==========================================
- Coverage 60.75% 60.75% -0.01%
==========================================
Files 4533 4533
Lines 122209 122211 +2
Branches 20483 20483
==========================================
+ Hits 74251 74252 +1
Misses 42719 42719
- Partials 5239 5240 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Wondering if we should trim the id in server side. |
...plugins/workspace/public/components/add_collaborators_modal/workspace_collaborator_input.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Binlong Gao <[email protected]>
b3294da
At first time, I want to implement this in server side, but found that we cannot differentiate new added collaborators and existing collaborators because the update workspace API only supports full update, not partial update, this will cause an issue that any existing collaboratorIds containing leading whitespace or trailing whitespace will be trimmed, this maybe a breaking change I think. |
|
ci group 16 failure not related to this change. |
Description
Trim collaborator ID when adding collaborators for workspace, if the leading whitespace or trailing whitespace are not trimmed, the collaborator may not work.
Issues Resolved
Resolves #10907
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration