-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[chat]Fix suggested actions not showing when tool calls are present #10918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chat]Fix suggested actions not showing when tool calls are present #10918
Conversation
Signed-off-by: Lin Wang <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10918 +/- ##
=======================================
Coverage 60.77% 60.77%
=======================================
Files 4533 4533
Lines 122246 122254 +8
Branches 20488 20489 +1
=======================================
+ Hits 74291 74297 +6
- Misses 42716 42717 +1
- Partials 5239 5240 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
|
All failed functional tests are due to |
Description
This PR fixes an issue where suggested actions were not appearing after tool calls. Previously, suggestions were only shown when the last message in the timeline was from the assistant, which failed to account for scenarios where tool calls followed the assistant's message. The updated logic now correctly displays suggestions by checking if the last assistant message appears after the last user message, ensuring that suggestions are shown even when tool calls are present in the conversation flow.
Screenshot
Changelog
Check List
yarn test:jestyarn test:jest_integration