Skip to content

Conversation

@wanglam
Copy link
Collaborator

@wanglam wanglam commented Nov 14, 2025

Description

This PR fixes an issue where suggested actions were not appearing after tool calls. Previously, suggestions were only shown when the last message in the timeline was from the assistant, which failed to account for scenarios where tool calls followed the assistant's message. The updated logic now correctly displays suggestions by checking if the last assistant message appears after the last user message, ensuring that suggestions are shown even when tool calls are present in the conversation flow.

Screenshot

image

Changelog

  • fix: suggested actions not appearing with tool calls

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@codecov
Copy link

codecov bot commented Nov 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.77%. Comparing base (1deca71) to head (96fd045).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10918   +/-   ##
=======================================
  Coverage   60.77%   60.77%           
=======================================
  Files        4533     4533           
  Lines      122246   122254    +8     
  Branches    20488    20489    +1     
=======================================
+ Hits        74291    74297    +6     
- Misses      42716    42717    +1     
- Partials     5239     5240    +1     
Flag Coverage Δ
Linux_1 26.57% <ø> (ø)
Linux_2 38.92% <ø> (ø)
Linux_3 39.47% <100.00%> (+<0.01%) ⬆️
Linux_4 33.74% <ø> (ø)
Windows_1 26.58% <ø> (ø)
Windows_2 38.90% <ø> (ø)
Windows_3 39.48% <100.00%> (+<0.01%) ⬆️
Windows_4 33.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Lin Wang <[email protected]>
ananzh
ananzh previously approved these changes Nov 14, 2025
SuZhou-Joe
SuZhou-Joe previously approved these changes Nov 14, 2025
Signed-off-by: Lin Wang <[email protected]>
@wanglam wanglam dismissed stale reviews from SuZhou-Joe and ananzh via 992d011 November 14, 2025 23:54
@wanglam
Copy link
Collaborator Author

wanglam commented Nov 15, 2025

All failed functional tests are due to create index block from open search side, should not related to this PR. Should safe to merge.

@wanglam wanglam merged commit 88c93cf into opensearch-project:main Nov 15, 2025
105 of 134 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants