[chat]Add close button for chatbot header #10924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lin Wang <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10924 +/- ##
=======================================
Coverage 60.77% 60.77%
=======================================
Files 4533 4533
Lines 122254 122254
Branches 20489 20489
=======================================
+ Hits 74299 74304 +5
+ Misses 42716 42711 -5
Partials 5239 5239
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Lin Wang <[email protected]>
wanglam
requested review from
AMoo-Miki,
BionIT,
Flyingliuhub,
LDrago27,
SuZhou-Joe,
ZilongX,
abbyhu2000,
ananzh,
ashwin-pc,
bandinib-amzn,
curq,
huyaboo,
joshuali925,
joshuarrrr,
kavilla,
manasvinibs,
mengweieric,
ruanyl,
sejli,
virajsanghvi,
xinruiba,
zengyan-amazon,
zhongnansu and
zhyuanqi
as code owners
wanglam
requested review from
Maosaic,
TackAdam,
angle943,
d-buckner,
paulstn,
ps48,
raintygao,
ruchidh and
sumukhswamy
as code owners
wanglam
changed the title
FriedhelmWS
reviewed
Nov 17, 2025
| interface ChatWindowProps { | ||
| layoutMode?: ChatLayoutMode; | ||
| onToggleLayout?: () => void; | ||
| onClose: ()=>void; |
Contributor
There was a problem hiding this comment.
Nit nit: seems a formatter problem here?
FriedhelmWS
approved these changes
Nov 17, 2025
Hailong-am
approved these changes
Nov 17, 2025
ruanyl
approved these changes
Nov 17, 2025
Collaborator
Author
|
Checked failed functional tests was not related to this PR, should safe to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add close button for chatbot header like screenshot below:
Changelog
Check List
yarn test:jestyarn test:jest_integration