Skip to content

[Explore] Add auto scroll when new line is added #10977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+10 −0
Open

[Explore] Add auto scroll when new line is added #10977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
10e96c6
add auto scroll when new line is added
abbyhu2000 Nov 26, 2025
4c54d24
Changeset file for PR #10977 created/updated
opensearch-changeset-bot[bot] Nov 26, 2025
7238b6f
fix unit test
abbyhu2000 Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/10977.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
fix:
- Add auto scroll when new line is added ([#10977](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/10977))
2 changes: 2 additions & 0 deletions ...ents/query_panel/query_panel_editor/use_query_panel_editor/use_query_panel_editor.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,8 @@ describe('useQueryPanelEditor', () => {
getOffsetAt: jest.fn(() => 10),
getValue: jest.fn(() => 'test query'),
getWordUntilPosition: jest.fn(() => ({ startColumn: 1, endColumn: 5 })),
getModel: jest.fn(() => ({ getLineCount: jest.fn() })),
revealLine: jest.fn(),
};

mockDataset = {
Expand Down
6 changes: 6 additions & 0 deletions ...omponents/query_panel/query_panel_editor/use_query_panel_editor/use_query_panel_editor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,6 +313,12 @@ export const useQueryPanelEditor = (): UseQueryPanelEditorReturnType => {
vertical: contentHeight > maxHeight ? 'visible' : 'hidden',
},
});

// Automatically scroll to the bottom when new lines are added
if (contentHeight > finalHeight) {
const lastLine = editor.getModel()?.getLineCount() || 0;
editor.revealLine(lastLine);
}
});

return () => {
Expand Down
Loading