Skip to content

Conversation

@opensearch-trigger-bot
Copy link
Contributor

Backport 0831c99 from #8364.

* feat/add_workspace_selector

Signed-off-by: Qxisylolo <[email protected]>

* Add_workspace_selector_to_left_nav, adjust style

Signed-off-by: Qxisylolo <[email protected]>

* Add_workspace_selector_to_left_nav, adjust styles

Signed-off-by: Qxisylolo <[email protected]>

* Add_workspace_selector_to_left_nav, keep the origin width of nav bar

Signed-off-by: Qxisylolo <[email protected]>

* Add_workspace_selector_to_left_nav, keep the origin width of nav bar, and adjust width

Signed-off-by: Qxisylolo <[email protected]>

* fix/the_UI_of_recent_assets, resolve comments

Signed-off-by: Qxisylolo <[email protected]>

* fix/the_UI_of_recent_assets, add tests

Signed-off-by: Qxisylolo <[email protected]>

* fix/the_UI_of_recent_assets, set scss

Signed-off-by: Qxisylolo <[email protected]>

* fix/the_UI_of_recent_assets, resolve conflicts

Signed-off-by: Qxisylolo <[email protected]>

* fix/the_UI_of_recent_assets, delete workspace list

Signed-off-by: Qxisylolo <[email protected]>

* feat: show nav group when not in a workspace

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: format scss file

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: optimize code

Signed-off-by: SuZhou-Joe <[email protected]>

* Update src/plugins/workspace/public/components/workspace_menu/workspace_menu.tsx

Co-authored-by: Yulong Ruan <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>

* fix: unit test

Signed-off-by: SuZhou-Joe <[email protected]>

---------

Signed-off-by: Qxisylolo <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Co-authored-by: SuZhou-Joe <[email protected]>
Co-authored-by: Yulong Ruan <[email protected]>
(cherry picked from commit 0831c99)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2024

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

@codecov
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 82.35294% with 12 lines in your changes missing coverage. Please review.

Project coverage is 61.01%. Comparing base (ea5f614) to head (231a901).
Report is 3 commits behind head on 2.x.

Files with missing lines Patch % Lines
...kspace_picker_content/workspace_picker_content.tsx 85.18% 2 Missing and 2 partials ⚠️
...mponents/workspace_selector/workspace_selector.tsx 85.71% 2 Missing and 2 partials ⚠️
...me/ui/header/collapsible_nav_group_enabled_top.tsx 0.00% 1 Missing and 1 partial ⚠️
...ublic/components/workspace_menu/workspace_menu.tsx 77.77% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              2.x    #8418   +/-   ##
=======================================
  Coverage   61.00%   61.01%           
=======================================
  Files        3748     3749    +1     
  Lines       89089    89124   +35     
  Branches    13911    13918    +7     
=======================================
+ Hits        54351    54376   +25     
- Misses      31366    31372    +6     
- Partials     3372     3376    +4     
Flag Coverage Δ
Linux_1 28.85% <82.35%> (+0.02%) ⬆️
Linux_2 56.46% <0.00%> (-0.01%) ⬇️
Linux_3 37.76% <0.00%> (-0.01%) ⬇️
Linux_4 30.08% <0.00%> (+<0.01%) ⬆️
Windows_1 28.87% <82.35%> (+0.02%) ⬆️
Windows_2 56.42% <0.00%> (-0.01%) ⬇️
Windows_3 37.76% <0.00%> (+<0.01%) ⬆️
Windows_4 30.08% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SuZhou-Joe SuZhou-Joe merged commit 027bdda into 2.x Oct 1, 2024
67 of 69 checks passed
@github-actions github-actions bot deleted the backport/backport-8364-to-2.x branch October 1, 2024 11:24
SuZhou-Joe added a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Oct 3, 2024
…roject#8364) (opensearch-project#8418)

* feat/add_workspace_selector



* Add_workspace_selector_to_left_nav, adjust style



* Add_workspace_selector_to_left_nav, adjust styles



* Add_workspace_selector_to_left_nav, keep the origin width of nav bar



* Add_workspace_selector_to_left_nav, keep the origin width of nav bar, and adjust width



* fix/the_UI_of_recent_assets, resolve comments



* fix/the_UI_of_recent_assets, add tests



* fix/the_UI_of_recent_assets, set scss



* fix/the_UI_of_recent_assets, resolve conflicts



* fix/the_UI_of_recent_assets, delete workspace list



* feat: show nav group when not in a workspace



* feat: format scss file



* feat: optimize code



* Update src/plugins/workspace/public/components/workspace_menu/workspace_menu.tsx




* fix: unit test



---------





(cherry picked from commit 0831c99)

Signed-off-by: Qxisylolo <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: SuZhou-Joe <[email protected]>
Co-authored-by: Yulong Ruan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autocut Skip the changelog verification check on backports failed changeset valued-contributor workspace

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants