ResolvedIndices: Introduced special case for no index in analyze requests #19849
Conversation
|
I have added no change log, as this fixes an issue in an unreleased change. I guess, no changelog is necessary then. |
|
❌ Gradle check result for 02e0a2e: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
nibix
force-pushed
the
analyze-action-index-resolution
branch
from
02e0a2e to
31dcb1b
Compare
|
❌ Gradle check result for 31dcb1b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
…ests. The analyze action has one special property that distinguishes it from all other actions extending TransportSingleShardAction: it can be executed without an index. This is a bit surprising, as we do not have a shard, while being in a class called "SingleShardAction". For this, the TransportAnalyzeAction does use a number of special cases. Thus, we also need to add a special case for the index resolution here. Signed-off-by: Nils Bandener <[email protected]>
nibix
force-pushed
the
analyze-action-index-resolution
branch
from
31dcb1b to
4762380
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19849 +/- ##
============================================
+ Coverage 73.08% 73.20% +0.12%
- Complexity 71063 71135 +72
============================================
Files 5754 5754
Lines 325262 325265 +3
Branches 47033 47033
============================================
+ Hits 237732 238126 +394
+ Misses 68380 67959 -421
- Partials 19150 19180 +30 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 participants
Description
This is a follow up to #18523 and fixes an issue with the analyze action.
The analyze action has one special property that distinguishes it from all other actions extending TransportSingleShardAction: it can be executed without an index. This is a bit surprising, as we do not have a shard, while being in a class called "SingleShardAction". For this, the TransportAnalyzeAction does use a number of special cases. Thus, we also need to add a special case for the index resolution here.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.