Fix incorrect SortOptions.Kind mapping in ScoreSort #1847
Closed
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baekgyu-kim
requested review from
Bukhtawar,
VachaShah,
Xtansia,
madhusudhankonda,
reta,
saratvemulapalli and
szczepanczykd
as code owners
Signed-off-by: Baekgyu <[email protected]>
Signed-off-by: Baekgyu <[email protected]>
baekgyu-kim
changed the title
Collaborator
|
Thanks @baekgyu-kim for working on this, I believe the issue is a bit more complicated than that. Right now the |
Contributor
Author
|
Hello @reta, I will close this PR for now. Have a great day. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change ensures that
ScoreSortcorrectly identifies itself as a score-based sort.Previously, the
_sortOptionsKind()method incorrectly returnedKind.Doc.This PR fixes the return value to
Kind.Scoreto align with its intended behavior.Issues Resolved
This pull request resolved the issue #1492 .
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.