Skip to content

fix diagnostics for async serialize and deserialize #951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix diagnostics for async serialize and deserialize #951

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/OpenSearch.Net/Serialization/DiagnosticsSerializerProxy.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,16 +106,16 @@ public T Deserialize<T>(Stream stream)
return _serializer.Deserialize<T>(stream);
}

public Task<object> DeserializeAsync(Type type, Stream stream, CancellationToken cancellationToken = default)
public async Task<object> DeserializeAsync(Type type, Stream stream, CancellationToken cancellationToken = default)
{
using (DiagnosticSource.Diagnose(DiagnosticSources.Serializer.Deserialize, _state))
return _serializer.DeserializeAsync(type, stream, cancellationToken);
return await _serializer.DeserializeAsync(type, stream, cancellationToken).ConfigureAwait(false);
}

public Task<T> DeserializeAsync<T>(Stream stream, CancellationToken cancellationToken = default)
public async Task<T> DeserializeAsync<T>(Stream stream, CancellationToken cancellationToken = default)
{
using (DiagnosticSource.Diagnose(DiagnosticSources.Serializer.Deserialize, _state))
return _serializer.DeserializeAsync<T>(stream, cancellationToken);
return await _serializer.DeserializeAsync<T>(stream, cancellationToken).ConfigureAwait(false);
}

public void Serialize<T>(T data, Stream stream, SerializationFormatting formatting = SerializationFormatting.None)
Expand All @@ -124,12 +124,12 @@ public void Serialize<T>(T data, Stream stream, SerializationFormatting formatti
_serializer.Serialize(data, stream, formatting);
}

public Task SerializeAsync<T>(T data, Stream stream, SerializationFormatting formatting = SerializationFormatting.None,
public async Task SerializeAsync<T>(T data, Stream stream, SerializationFormatting formatting = SerializationFormatting.None,
CancellationToken cancellationToken = default
)
{
using (DiagnosticSource.Diagnose(DiagnosticSources.Serializer.Serialize, _state))
return _serializer.SerializeAsync(data, stream, formatting, cancellationToken);
await _serializer.SerializeAsync(data, stream, formatting, cancellationToken).ConfigureAwait(false);
}

}
Expand Down