Add support for regex in ComponentMatcher Suite#616
Merged
openshift-merge-bot[bot] merged 7 commits intoopenshift-eng:mainfrom Feb 25, 2026
Merged
Add support for regex in ComponentMatcher Suite#616openshift-merge-bot[bot] merged 7 commits intoopenshift-eng:mainfrom
openshift-merge-bot[bot] merged 7 commits intoopenshift-eng:mainfrom
Conversation
Contributor
Author
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
etirta
suggested changes
Feb 21, 2026
Co-authored-by: Edoardo Tirtarahardja <54961875+etirta@users.noreply.github.com>
Contributor
Author
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
stbenjam
reviewed
Feb 24, 2026
etirta
reviewed
Feb 24, 2026
etirta
reviewed
Feb 24, 2026
Co-authored-by: Edoardo Tirtarahardja <54961875+etirta@users.noreply.github.com>
Contributor
|
Thx @oharan2 for all the works. I'm signing off on this because the initiative came from me. But my LGTM don't have real consequences on this PR workflow 😅. |
Member
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oharan2, stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main changes:
New API: Add SuiteRegEx for regex-based suite matching.
ComponentMatchergets aSuiteRegExfield andIsSuiteRegExTest() to matchtest.Suitewith a regex, keeping backward compatibility with existing Suite usage.Tests: Coverage for
SuiteRegEx-only, exactSuite-only, and combined (both/neither matches).