-
Notifications
You must be signed in to change notification settings - Fork 54
Replace redhat-appstudio-tekton-catalog references #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
red-hat-konflux
wants to merge
11
commits into
main
Choose a base branch
from
konflux/references-replacement/main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fixes concurrent map write in integration test * Add core framework for shared microservice patterns - Create pkg/core/ with generic CRUD services, DAOs, and controllers - Implement type-safe operations using Go generics - Add event-driven architecture with OnUpsert/OnDelete handlers - Migrate database utilities (Model, CreateFK) to core framework - Update existing components to use core Meta type - Maintain backward compatibility with existing code - Add comprehensive testing and documentation 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> --------- Co-authored-by: Claude <[email protected]>
* Integrate rh-trex-core library for enhanced error handling and controller framework - Migrate TRex to use external rh-trex-core library dependency - Add enhanced error handling with PII sanitization and constraint detection - Implement dual controller system (legacy + core) for seamless transition - Update GORM postgres driver to v1.5.9 for compatibility - Remove internal pkg/core/ directory (now external library) - Update CLAUDE.md with comprehensive core library integration documentation - Add settings.local.json to .gitignore 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> * Remove settings.local.json from repository tracking - Remove .claude/settings.local.json from git tracking (should be ignored) - File is already properly configured in .gitignore 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> --------- Co-authored-by: Claude <[email protected]>
) - Add ProjectCamelCase field to generator for dynamic API method names - Update test template to use {{.ProjectCamelCase}} instead of hardcoded "RhTrex" - Fix clone command to preserve rh-trex-core imports during project cloning - Add toCamelCase() helper function for proper name conversion 🤖 Generated with [Claude Code](https://claude.ai/code) Co-authored-by: Claude <[email protected]>
* Fix clone command to preserve rh-trex-core library imports Prevent replacement of rh-trex-core imports during cloning by adding exclusion conditions to avoid breaking core library dependencies. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> * Fix TRex clone command to preserve rh-trex-core dependencies - Modify clone logic to use line-by-line replacement that preserves any line containing "rh-trex-core" - Prevents cloned projects from breaking due to incorrect core library dependency replacement - Update CLAUDE.md with comprehensive clone command documentation including the fix details - Verified: complete clone → build → database → test workflow now works end-to-end Fixes issue where cloned projects would fail to build with "module not found" errors for transformed core library paths. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> --------- Co-authored-by: Claude <[email protected]>
- Add INSTANTAPI.md: Complete Instant API workflow documentation - Add CLONING.md: TRex cloning knowledge base with bug fixes - Add MODEL.md: UML modeling guidelines for business domains - Fix generator service locator registration in scripts/generator.go - Fix clone command self-corruption in cmd/trex/clone/cmd.go - Update CLAUDE.md with comprehensive development guidelines - Add integration test helper improvements in test/helper.go 🤖 Generated with [Claude Code](https://claude.ai/code) Co-authored-by: Claude <[email protected]>
- Fix generator service locator pattern matching to use proper comment markers - Add automatic route and migration registration with comment markers - Restructure documentation: move running instructions to RUNNING.md - Update NEWMODEL.md Rule 0 to make any test failure fatal - Fix ASCII architecture diagram alignment issues 🤖 Generated with [Claude Code](https://claude.ai/code) Co-authored-by: Claude <[email protected]>
* Clean up failed entity generation and fix generator bugs - Remove FamousLandmarks and DogPark artifacts from service locators and migrations - Fix generator route registration template bug - Comment out flaky racing test without advisory lock - Update documentation for automatic continuation rules 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> * Fix duplicate migration ID bug in generator Resolves critical issue where generating multiple entities rapidly creates identical migration timestamps, causing gormigrate failures and blocking integration tests. Changes: - Add seconds and microseconds to migration timestamp format - Prevents collision when generating multiple entities in same minute - Maintains backward compatibility with existing migration format Before: 202507172225 (minute precision, causes duplicates) After: 20250717223411200051 (microsecond precision, always unique) Fixes identified through ocmai clone testing where 5 entities (Circus, Performer, Animal, Act, Show) all received timestamp 202507172225, causing "Duplicated migration ID" error. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> --------- Co-authored-by: Claude <[email protected]>
* Complete framework extraction Phase 1 to rh-trex-core library This commit implements Phase 1 of the framework extraction plan outlined in EXTRACTION.md, creating a shared rh-trex-core library to resolve clone self-sufficiency issues. ## Framework Extraction Changes: ### Core Library Integration: - Add rh-trex-core dependency with local replace directive - Implement adapter pattern in pkg/db/transactions.go for interface compatibility - Update imports to use core library components (transaction, context, factories) ### TRex Updates: - Maintain backward compatibility through adapter interfaces - Update factory pattern to use core library KSUID generation - Preserve existing functionality while enabling shared framework ### Test Entity Cleanup: - Remove TestEntity references from presenters, routes, controllers - Clean up OpenAPI specifications and regenerate - Ensure clean build with make test passing ## Technical Achievements: ### Problem Solved: - ✅ Clone self-sufficiency: Core database components now shared via rh-trex-core - ✅ Consistent ID generation: KSUID factories shared across all projects - ✅ Framework reusability: Critical components available for all TRex clones ### Validation Results: - ✅ All unit tests pass (make test) - ✅ OpenAPI generation successful - ✅ Clone generation preserves core library dependencies - ✅ Build compatibility maintained ## Next Steps: - Phase 2: Extract auth, logging, and utility components - Validate ocmai clone with updated framework - Complete framework extraction as outlined in EXTRACTION.md 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> * Refactor cloning system to standalone script Move clone command from trex binary to standalone cloner.go script. This prevents scripts from being included in cloned projects and provides cleaner separation. Changes: - Move cmd/trex/clone/cmd.go to scripts/cloner.go - Remove clone command and imports from main.go - Update CLAUDE.md documentation for new cloning approach - Delete unused openapitools.json file - Clean up service locator formatting in types.go 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> * Implement plugin architecture with auto-discovery service registry Major refactor to consolidate entity logic into single plugin files with automatic framework registration. This eliminates manual framework editing when adding new entities and provides true drop-in functionality. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> --------- Co-authored-by: Claude <[email protected]>
* Complete framework extraction Phase 1 to rh-trex-core library This commit implements Phase 1 of the framework extraction plan outlined in EXTRACTION.md, creating a shared rh-trex-core library to resolve clone self-sufficiency issues. - Add rh-trex-core dependency with local replace directive - Implement adapter pattern in pkg/db/transactions.go for interface compatibility - Update imports to use core library components (transaction, context, factories) - Maintain backward compatibility through adapter interfaces - Update factory pattern to use core library KSUID generation - Preserve existing functionality while enabling shared framework - Remove TestEntity references from presenters, routes, controllers - Clean up OpenAPI specifications and regenerate - Ensure clean build with make test passing - ✅ Clone self-sufficiency: Core database components now shared via rh-trex-core - ✅ Consistent ID generation: KSUID factories shared across all projects - ✅ Framework reusability: Critical components available for all TRex clones - ✅ All unit tests pass (make test) - ✅ OpenAPI generation successful - ✅ Clone generation preserves core library dependencies - ✅ Build compatibility maintained - Phase 2: Extract auth, logging, and utility components - Validate ocmai clone with updated framework - Complete framework extraction as outlined in EXTRACTION.md 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> * Refactor cloning system to standalone script Move clone command from trex binary to standalone cloner.go script. This prevents scripts from being included in cloned projects and provides cleaner separation. Changes: - Move cmd/trex/clone/cmd.go to scripts/cloner.go - Remove clone command and imports from main.go - Update CLAUDE.md documentation for new cloning approach - Delete unused openapitools.json file - Clean up service locator formatting in types.go 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> * Enhance thread safety and service management patterns - Add mutex protection to service registry and advisory locks - Update plugin templates with improved service accessor patterns - Clean up OpenAPI spec by removing test entity references - Improve test framework to handle various field types properly 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> * Enhance TRex cloning and entity generation workflow - Update INSTANTAPI.md with Phase 2 entity generation process - Improve cloner.go with auto-detection and comprehensive replacements - Add project auto-detection to generator.go with better UX feedback - Ensure SQL-safe naming for database variables in clones 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> --------- Co-authored-by: Claude <[email protected]>
│ │ │ Major improvements to TRex: │ │ - Reorganize scattered documentation into user-journey-based structure in /docs/ │ │ - Implement plugin architecture with auto-registration, eliminating manual service locator edits │ │ - Enhance entity generator with complete CRUD plugin generation │ │ - Improve cloning script for cleaner new project creation │ │ - Update CLAUDE.md with modern AI assistance patterns │ │ - Add comprehensive guides for all user workflows │ │ │ │ The plugin architecture resolves previous service locator bugs and enables │ │ atomic entity management. Documentation now follows progressive disclosure │ │ with clear user paths from getting started to production deployment. │ │ │ │ 🤖 Generated with [Claude Code](https://claude.ai/code) │ │ │ │ Co-Authored-By: Claude <[email protected]>
ef24528 to
0f407e6
Compare
0f407e6 to
faa26bb
Compare
redhat-appstudio-tekton-catalog is deprecated, replace the references with equivalent konflux-ci/tekton-catalog references
faa26bb to
49c97c3
Compare
Contributor
Author
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
0.2->0.20.1->0.10.1->0.10.4->0.40.1->0.10.2->0.20.1->0.10.1->0.10.2->0.20.1->0.10.1->0.10.2->0.2This is a special PR that replaces
quay.io/redhat-appstudio-tekton-catalog/task-buildahwith the community suggested minimal stable replacement version.This is a special PR that replaces
quay.io/redhat-appstudio-tekton-catalog/task-clair-scanwith the community suggested minimal stable replacement version.This is a special PR that replaces
quay.io/redhat-appstudio-tekton-catalog/task-clamav-scanwith the community suggested minimal stable replacement version.This is a special PR that replaces
quay.io/redhat-appstudio-tekton-catalog/task-deprecated-image-checkwith the community suggested minimal stable replacement version.This is a special PR that replaces
quay.io/redhat-appstudio-tekton-catalog/task-git-clonewith the community suggested minimal stable replacement version.This is a special PR that replaces
quay.io/redhat-appstudio-tekton-catalog/task-initwith the community suggested minimal stable replacement version.This is a special PR that replaces
quay.io/redhat-appstudio-tekton-catalog/task-inspect-imagewith the community suggested minimal stable replacement version.This is a special PR that replaces
quay.io/redhat-appstudio-tekton-catalog/task-prefetch-dependencieswith the community suggested minimal stable replacement version.This is a special PR that replaces
quay.io/redhat-appstudio-tekton-catalog/task-sast-snyk-checkwith the community suggested minimal stable replacement version.This is a special PR that replaces
quay.io/redhat-appstudio-tekton-catalog/task-show-sbomwith the community suggested minimal stable replacement version.This is a special PR that replaces
quay.io/redhat-appstudio-tekton-catalog/task-source-buildwith the community suggested minimal stable replacement version.This is a special PR that replaces
quay.io/redhat-appstudio-tekton-catalog/task-summarywith the community suggested minimal stable replacement version.Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
To execute skipped test pipelines write comment
/ok-to-test.This PR has been generated by MintMaker (powered by Renovate Bot).