Skip to content

OCPBUGS-77538: (Backport) Override prefilled rendezvousIP#263

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.21from
pawanpinjarkar:cherrypick-AGENT-1447
Mar 2, 2026
Merged

OCPBUGS-77538: (Backport) Override prefilled rendezvousIP#263
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.21from
pawanpinjarkar:cherrypick-AGENT-1447

Conversation

@pawanpinjarkar
Copy link
Contributor

@pawanpinjarkar pawanpinjarkar commented Feb 26, 2026

This is a manual backportof https://issues.redhat.com/browse/AGENT-1467 Override prefilled rendezvousIP #256

If an user has provided rendezvousIP from the SaaS UI, the TUI will now
show that prefilled rendezvousIP and user will have an option to modify it.

- Detect interactive mode via sentinel file (/etc/assisted/interactive-ui)
- Support prefilled rendezvous IP passed from SaaS UI
- Display 20-second timeout when interactive mode has prefilled rendezvous IP
- Moved "Configure Network" to the first screen
- Enhanced navigation on rendezvous IP page with 4 focusable elements
- Added new tests
- Added a new Makefile target, `make test`

The TUI now handles three distinct flows:
1. Interactive mode + prefilled IP from SaaS UI: Shows timeout with an option to modify the rendezvous IP
2. Interactive mode without IP: Shows rendezvous IP form directly
3. Non-interactive mode: Shows registry check screen (existing behavior)

Co-Authored-By: Claude Sonnet 4.5 noreply@anthropic.com
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 26, 2026

@pawanpinjarkar: This pull request references AGENT-1447 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.z" version, but no target version was set.

Details

In response to this:

This is a manual cherry-pick of https://issues.redhat.com/browse/AGENT-1467 Override prefilled rendezvousIP #256

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 26, 2026
@pawanpinjarkar pawanpinjarkar changed the title AGENT-1447: Override prefilled rendezvousIP AGENT-1431: Backport feature NoRegistryClusterInstall to 4.21 Feb 26, 2026
@openshift-ci openshift-ci bot requested review from celebdor and zaneb February 26, 2026 19:25
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 26, 2026

@pawanpinjarkar: This pull request references AGENT-1431 which is a valid jira issue.

Details

In response to this:

This is a manual cherry-pick of https://issues.redhat.com/browse/AGENT-1467 Override prefilled rendezvousIP #256

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link

openshift-ci bot commented Feb 26, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pawanpinjarkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2026
@bfournie
Copy link
Contributor

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Feb 26, 2026
@pawanpinjarkar
Copy link
Contributor Author

/verified by @pawanpinjarkar

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Feb 26, 2026
@openshift-ci-robot
Copy link

@pawanpinjarkar: This PR has been marked as verified by @pawanpinjarkar.

Details

In response to this:

/verified by @pawanpinjarkar

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link

openshift-ci bot commented Feb 26, 2026

@pawanpinjarkar: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Contributor

@rwsu rwsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2026
@pawanpinjarkar pawanpinjarkar changed the title AGENT-1431: Backport feature NoRegistryClusterInstall to 4.21 OCPBUGS-77538: (Backport) Override prefilled rendezvousIP Mar 2, 2026
@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Mar 2, 2026
@openshift-ci-robot
Copy link

@pawanpinjarkar: This pull request references Jira Issue OCPBUGS-77538, which is invalid:

  • expected Jira Issue OCPBUGS-77538 to depend on a bug targeting a version in 4.22.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is a manual cherry-pick of https://issues.redhat.com/browse/AGENT-1467 Override prefilled rendezvousIP #256

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pawanpinjarkar
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link

@pawanpinjarkar: This pull request references Jira Issue OCPBUGS-77538, which is invalid:

  • expected the bug to target either version "4.21." or "openshift-4.21.", but it targets "4.22.0" instead
  • expected Jira Issue OCPBUGS-77538 to depend on a bug targeting a version in 4.22.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pawanpinjarkar
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 2, 2026

@pawanpinjarkar: This pull request references Jira Issue OCPBUGS-77538, which is invalid:

  • expected the bug to target either version "4.21." or "openshift-4.21.", but it targets "4.22.0" instead
  • dependent bug AGENT-1447 is not in the required OCPBUGS project

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pawanpinjarkar
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link

@pawanpinjarkar: This pull request references Jira Issue OCPBUGS-77538, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pawanpinjarkar
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 2, 2026
@openshift-ci-robot
Copy link

@pawanpinjarkar: This pull request references Jira Issue OCPBUGS-77538, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.z) matches configured target version for branch (4.21.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-77540 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-77540 targets the "4.22.0" version, which is one of the valid target versions: 4.22.0
  • bug has dependents

Requesting review from QA contact:
/cc @mhanss

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from mhanss March 2, 2026 15:13
@openshift-merge-bot openshift-merge-bot bot merged commit adc0f61 into openshift:release-4.21 Mar 2, 2026
10 checks passed
@openshift-ci-robot
Copy link

@pawanpinjarkar: Jira Issue Verification Checks: Jira Issue OCPBUGS-77538
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-77538 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

This is a manual backportof https://issues.redhat.com/browse/AGENT-1467 Override prefilled rendezvousIP #256

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants