AGENT-1453: Add a flag to provide a custom appliance image#264
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@andfasano: This pull request references AGENT-1453 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andfasano The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/test ? |
|
/test e2e-agent-compact-ipv4-iso-no-registry |
|
@andfasano: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
/verified by @andfasano |
openshift-ci-robot
added
the
verified
|
@andfasano: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
| function build_live_iso() { | ||
| if [ ! -f "${appliance_work_dir}"/appliance.iso ]; then | ||
| local appliance_image=registry.ci.openshift.org/ocp/${major_minor_version}:agent-preinstall-image-builder | ||
| local appliance_image="${APPLIANCE_IMAGE:-registry.ci.openshift.org/ocp/${major_minor_version}:agent-preinstall-image-builder}" |
There was a problem hiding this comment.
Nit - for later, should fix the formatting (line has one less intent than following)
| --arch) ARCH="$2"; shift ;; | ||
| --pull-secret-file) PULL_SECRET_FILE="$2"; shift ;; | ||
| --ssh-key-file) SSH_KEY_FILE="$2"; shift ;; | ||
| --appliance-image) APPLIANCE_IMAGE="$2"; shift ;; |
There was a problem hiding this comment.
Nit - for later, should add this to README.md
|
/override kflux-prd-rh02/ove-ui-iso-on-pull-request Failure does not seem related to the current patch |
|
@andfasano: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override "Konflux kflux-prd-rh02 / ove-ui-iso-on-pull-request" |
|
@andfasano: Overrode contexts on behalf of andfasano: Konflux kflux-prd-rh02 / ove-ui-iso-on-pull-request DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override "Red Hat Konflux / ove-ui-enterprise-contract / ove-ui-iso" |
|
@andfasano: Overrode contexts on behalf of andfasano: Red Hat Konflux / ove-ui-enterprise-contract / ove-ui-iso DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-merge-bot
bot
merged commit 14714d3
into
openshift:main
3 participants
This patch adds a new flag to the build-ove-image script to support a custom appliance image. It will be used only for testing Appliance presubmit CI jobs