deprecate all Openshift templates related code#4952
deprecate all Openshift templates related code#4952droslean wants to merge 1 commit intoopenshift:mainfrom
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
WalkthroughThis PR removes OpenShift template and installer/Ansible cluster test support across the codebase: deletes template parsing, execution, migration, related types, fixtures, and steps, and replaces or narrows test/config paths toward multi-stage/container-based tests. No replacement template subsystem is added. Changes
Estimated code review effort🎯 5 (Critical) | ⏱️ ~120 minutes ✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
|
/hold Holding to babyshit this after merge. |
3042050 to
6ae5712
Compare
Signed-off-by: Nikolaos Moraitis <nmoraiti@redhat.com>
6ae5712 to
fb8181c
Compare
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
pkg/defaults/defaults.go (1)
817-826:⚠️ Potential issue | 🟠 MajorInclude unresolved
MultiStageTestConfigurationtests in the build graph.The condition at line 819 only processes literal test configurations. However, registry resolution is optional—if no
registryPathis provided toloadConfig, unresolvedMultiStageTestConfigurationtests are never converted to literal form and will be silently dropped from the graph. This is a silent failure that hides misconfiguration.Include
test.MultiStageTestConfigurationin the condition to ensure these tests are added to the step graph, or guarantee that all configs enteringFromConfigStatichave been resolved:Suggested fix
- if test.ContainerTestConfiguration != nil || test.MultiStageTestConfigurationLiteral != nil { + if test.ContainerTestConfiguration != nil || test.MultiStageTestConfigurationLiteral != nil || test.MultiStageTestConfiguration != nil {🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@pkg/defaults/defaults.go` around lines 817 - 826, The loop over config.Tests is currently only adding tests with ContainerTestConfiguration or MultiStageTestConfigurationLiteral to buildSteps, which drops unresolved MultiStageTestConfiguration entries; update the condition in the loop to also include test.MultiStageTestConfiguration (i.e. treat tests with MultiStageTestConfiguration as valid candidates to append to buildSteps) or alternatively ensure loadConfig/FromConfigStatic always resolves MultiStageTestConfiguration into MultiStageTestConfigurationLiteral before this loop; reference symbols: config.Tests, test.MultiStageTestConfiguration, test.MultiStageTestConfigurationLiteral, test.ContainerTestConfiguration, loadConfig, FromConfigStatic, buildSteps, api.StepConfiguration.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@pkg/defaults/defaults.go`:
- Around line 817-826: The loop over config.Tests is currently only adding tests
with ContainerTestConfiguration or MultiStageTestConfigurationLiteral to
buildSteps, which drops unresolved MultiStageTestConfiguration entries; update
the condition in the loop to also include test.MultiStageTestConfiguration (i.e.
treat tests with MultiStageTestConfiguration as valid candidates to append to
buildSteps) or alternatively ensure loadConfig/FromConfigStatic always resolves
MultiStageTestConfiguration into MultiStageTestConfigurationLiteral before this
loop; reference symbols: config.Tests, test.MultiStageTestConfiguration,
test.MultiStageTestConfigurationLiteral, test.ContainerTestConfiguration,
loadConfig, FromConfigStatic, buildSteps, api.StepConfiguration.
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@droslean: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: droslean, petr-muller The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
man that feels good /meow |
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |

Cleanup all template-related code from all tools that were using templates.
/cc @openshift/test-platform