NO-JIRA: manifests-gen: use real version for cluster-capi-operator dependency#462
NO-JIRA: manifests-gen: use real version for cluster-capi-operator dependency#462RadekManak wants to merge 1 commit intoopenshift:mainfrom
Conversation
…ndency Remove the local path `replace` directive for cluster-capi-operator from manifests-gen/go.mod and use a resolvable pseudo-version instead. The go.work workspace handles local resolution during development, while external consumers can now resolve the dependency without the replace directive which is ignored outside the main module.
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
openshift-ci-robot
added
the
jira/valid-reference
|
@RadekManak: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
Scheduling tests matching the |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: theobarberbany The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/override ci/prow/e2e-aws-capi-techpreview ci/prow/e2e-aws-ovn-serial-1of2 ci/prow/e2e-metal3-capi-techpreview ci/prow/e2e-openstack-ovn-techpreview ci/prow/regression-clusterinfra-aws-ipi-techpreview-capi This is no-op change with regard to build image. |
|
@RadekManak: Overrode contexts on behalf of RadekManak: ci/prow/e2e-aws-capi-techpreview, ci/prow/e2e-aws-ovn-serial-1of2, ci/prow/e2e-metal3-capi-techpreview, ci/prow/e2e-openstack-ovn-techpreview, ci/prow/regression-clusterinfra-aws-ipi-techpreview-capi DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@RadekManak: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/verified by radekmanak |
openshift-ci-robot
added
the
verified
|
@RadekManak: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
/hold
Please don't merge this yet. I don't think this is right.
See https://redhat-internal.slack.com/archives/GE2HQ9QP4/p1771428129187909
openshift-ci
bot
added
the
do-not-merge/hold
|
After more consideration, I'm strongly opposed to merging this. It will decouple manifests-gen from its parent directory, which will make it impossible to merge a single change which spans both modules. There are plenty of examples of go modules which are structured like this. I think we need to focus on finding a canonical pattern for how consumers of the submodule are expected to handle it. |
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
5 participants
Remove the local path
replacedirective for cluster-capi-operator from manifests-gen/go.mod and use a resolvable pseudo-version instead. The go.work workspace handles local resolution during development, while external consumers can now resolve the dependency without the replace directive which is ignored outside the main module.This fixes providers not being able to resolve the cluster-capi-operator dependency when installing or updating manfiests-gen.