script: add IRQBALANCE_BANNED_CPULIST variable#1420
script: add IRQBALANCE_BANNED_CPULIST variable#1420Tal-or wants to merge 4 commits intoopenshift:mainfrom
Conversation
|
/hold depends on cri-o/cri-o#8931 Closed by mistake |
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Tal-or The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
same as #1350 which was closed by mistake |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci
bot
added
the
lifecycle/stale
openshift-merge-robot
added
the
needs-rebase
|
/remove-lifecycle stale |
openshift-ci
bot
removed
the
lifecycle/stale
|
@Tal-or lets revisit this PR |
new version of irqbalance start using IRQBALANCE_BANNED_CPULIST to mark the banned CPUs that are not suppose to participate in the irq balancing. We're setting the new variable with a default value `-` which means that all CPUs are participating in the irq balancing. Signed-off-by: Talor Itzhak <titzhak@redhat.com>
This is only needed for cases when more control is required on the restore flow. cri-o/cri-o@e158549 In our case we do not need the restore flow at all, because the default behavior of the dynamic irqbalancing provided by cri-o is good enough for us. hence, we disable the restore flow completely. Signed-off-by: Talor Itzhak <titzhak@redhat.com>
Signed-off-by: Talor Itzhak <titzhak@redhat.com>
Signed-off-by: Talor Itzhak <titzhak@redhat.com>
Tal-or
force-pushed
the
banned_cpus_new_var
branch
from
dbdf5a5 to
d7bcad3
Compare
openshift-merge-robot
removed
the
needs-rebase
|
|
||
| ${SED} -i '/^\s*IRQBALANCE_BANNED_CPULIST\b/d' "${IRQBALANCE_CONF}" || exit 0 | ||
| # A CPU list that represents the CPUs that will not have any irq's assigned to them on rebalance. | ||
| # '-' is a special value that means all CPUs are participating in load balancing (none is banned). |
There was a problem hiding this comment.
Has this been confirmed upstream? I don't see any issue or documentation PR there to describe the semantics of '-'. My worry is that this is undocumented and therefore subject to change by irqbalance maintainers. Thanks!
There was a problem hiding this comment.
Opened a doc PR: Irqbalance/irqbalance#356
|
/retest |
|
@Tal-or: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
5 participants
A new version of irqbalance start using IRQBALANCE_BANNED_CPULIST to mark the banned CPUs
that are not suppose to participate in the irq balancing.
We're setting the new variable with a default value - which
means that all CPUs are participating in the irq balancing.
Signed-off-by: Talor Itzhak titzhak@redhat.com