Skip to content

refactor: simplify redundant error checking conditions #1320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vprashar2929 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: simplify redundant error checking conditions #1320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/resourcebuilder/apps.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ func (b *builder) modifyDeployment(ctx context.Context, deployment *appsv1.Deplo
if err != nil && !errors.IsNotFound(err) {
return err
}
if !errors.IsNotFound(err) {
if err == nil {
lbURL, err := url.Parse(infrastructureConfig.Status.APIServerInternalURL)
if err != nil {
return err
Expand Down
4 changes: 2 additions & 2 deletions pkg/cvo/upgradeable.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,7 @@ func (check *clusterAdminAcksCompletedUpgradeable) Check() *configv1.ClusterOper
var message string
if apierrors.IsNotFound(err) {
message = fmt.Sprintf("%s configmap not found.", internal.AdminGatesConfigMap)
} else if err != nil {
} else {
message = fmt.Sprintf("Unable to access configmap %s, err=%v.", internal.AdminGatesConfigMap, err)
}
klog.Error(message)
Expand All @@ -394,7 +394,7 @@ func (check *clusterAdminAcksCompletedUpgradeable) Check() *configv1.ClusterOper
var message string
if apierrors.IsNotFound(err) {
message = fmt.Sprintf("%s configmap not found.", internal.AdminAcksConfigMap)
} else if err != nil {
} else {
message = fmt.Sprintf("Unable to access configmap %s, err=%v.", internal.AdminAcksConfigMap, err)
}
klog.Error(message)
Expand Down