CORS-3897: Dual stack support for cluster manifest & VNet#10319
CORS-3897: Dual stack support for cluster manifest & VNet#10319jhixson74 wants to merge 4 commits intoopenshift:mainfrom
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@jhixson74: This pull request references CORS-3901 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
jhixson74
force-pushed
the
main-ipv6-azure
branch
3 times, most recently
from
bc4a130 to
53acac8
Compare
jhixson74
changed the title
jhixson74
force-pushed
the
main-ipv6-azure
branch
3 times, most recently
from
135e207 to
fa580ef
Compare
jhixson74
changed the title
|
@jhixson74: This pull request references CORS-3897 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
jhixson74
force-pushed
the
main-ipv6-azure
branch
2 times, most recently
from
37cc589 to
44ded41
Compare
|
/retest-required |
|
|
||
| // XXX: I don't know if this is necessary, but copying it over for now | ||
| // XXX: 10.1.0.0 is node CIDR, where does 10.2.0.0 come from? | ||
| virtualNetworkAddressPrefixes = append(virtualNetworkAddressPrefixes, "10.1.0.0/16") |
There was a problem hiding this comment.
shouldn't this be 10.0.0.0 and 10.1.0.0 ? At least that's what CAPZ is expecting
There was a problem hiding this comment.
what happens when the user specifies the ipv6 cidrs? should we add them too?
There was a problem hiding this comment.
Any cidrs spcified in the install-config, are added a couple lines above this. Adding these may not even be necessary. At one point when I was testing, these somehow magically were necessary. I can certainly remove this and see if things still work as expected.
- Support IPv4 and IPv6 CIDRs - Set VNet CIDR blocks - Set subnet CIDR blocks https://issues.redhat.com/browse/CORS-3897
jhixson74
force-pushed
the
main-ipv6-azure
branch
from
44ded41 to
6e5e796
Compare
|
@jhixson74: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
No description provided.