Skip to content

support for network interface deletion on subnet#10325

Open
taliandre49 wants to merge 2 commits intoopenshift:mainfrom
taliandre49:network-Interface-PR
Open

support for network interface deletion on subnet#10325
taliandre49 wants to merge 2 commits intoopenshift:mainfrom
taliandre49:network-Interface-PR

Conversation

@taliandre49
Copy link

Enhance PowerVS subnet deletion logic to automatically handle attached network interfaces that block subnet removal (e.g., 409 Conflict).

Details

  • Add deleteNetworkInterfaces to enumerate and delete all NICs attached to a given subnet before retrying subnet deletion.
  • Introduce isNetworkInterfaceError helper to detect errors indicating subnet deletion is blocked by existing IP allocations or 409 conflicts.
  • Update deletePowerSubnet to:
    - Detect NIC-related deletion failures
    - Log the condition
    - Attempt NIC cleanup
    - Return a wrapped error to trigger the existing retry mechanism

…ubnet destruction

Signed-off-by: Natalia Jordan <natalia.jordan@ibm.com>
@openshift-ci openshift-ci bot requested review from clnperez and mjturek February 19, 2026 16:01
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 19, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clnperez for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 19, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 19, 2026

Hi @taliandre49. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

…on error that failed before destroyPowerSubnets() logic ran

Signed-off-by: Natalia Jordan <natalia.jordan@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant