AGENT-1417: Add kind verification in InternalReleaseImage check#10332
AGENT-1417: Add kind verification in InternalReleaseImage check#10332bfournie wants to merge 1 commit intoopenshift:mainfrom
Conversation
|
@bfournie: This pull request references AGENT-1417 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
/jira refresh |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@bfournie: This pull request references AGENT-1417 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Instead of just checking if /etc/assisted/extra-manifests/internalreleaseimage.yaml exists, validate that any file in /etc/assisted/extra-manifests/ contains kind: InternalReleaseImage. This makes the check more robust and filename-agnostic.
bfournie
force-pushed
the
iri-size-check
branch
from
d7484f4 to
d299258
Compare
|
@bfournie: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
In order to increase the expected storage size a check is done for the existence of a file with IRI. This adds a check to confirm that the file actually contains a resource of type InternalReleaseImage.