Skip to content

Conversation

@Neha-dot-Yadav
Copy link
Contributor

This PR reduces the grace_period for the ipi-install-powervs-install step from 2 hours to 10 minutes and adds a trap 'dump_resources' TERM handler to ensure resource collection occurs when the step terminates.

Background
Currently, our step fails if timeout is reached, but the underlying installation script continues running for an additional 2 hours, which is the configured grace period.
During this extended grace period, the installation eventually completes successfully, but the step is still marked as Failed because it exceeded the timeout.
This leads to unnecessary resource consumption and confusion, as clusters are being created successfully but marked as failed runs.

The dump_resources function previously executed only after openshift-install wait-for install-complete, which can take up to 2 hours. With the reduced grace period(10m), the script would now terminate before reaching that point, resulting in missing debug artifacts. Adding a TERM trap ensures dump_resources runs automatically on termination, allowing resource data to be collected even when the step times out or fails early.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 6, 2025
@openshift-ci openshift-ci bot requested review from clnperez and rpsene November 6, 2025 11:11
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 6, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Neha-dot-Yadav
Once this PR has been reviewed and has the lgtm label, please assign mjturek for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@Neha-dot-Yadav: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-installer-main-e2e-powervs-capi-ovn openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.22-e2e-powervs-capi-ovn openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.21-e2e-powervs-capi-ovn openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.20-e2e-powervs-capi-ovn openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.19-e2e-powervs-capi-ovn openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.18-e2e-powervs-capi-ovn openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.17-e2e-powervs-ovn openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.16-altinfra-e2e-powervs-capi-ovn openshift/installer presubmit Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.18-ppc64le-nightly-powervs-ipi-f14-destructive N/A periodic Registry content changed
periodic-ci-openshift-multiarch-master-nightly-4.19-ocp-e2e-ovn-powervs-capi-multi-p-p N/A periodic Registry content changed
periodic-ci-openshift-multiarch-master-nightly-4.17-ocp-e2e-ovn-powervs-capi-multi-p-p N/A periodic Registry content changed
periodic-ci-openshift-multiarch-master-nightly-4.13-ocp-e2e-serial-ovn-ppc64le-powervs N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.16-ppc64le-nightly-powervs-ipi-f28-destructive N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.21-ppc64le-nightly-powervs-ipi-f7-destructive N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.20-ppc64le-nightly-powervs-ipi-f7-destructive N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.17-ppc64le-nightly-powervs-ipi-f14-destructive N/A periodic Registry content changed
periodic-ci-openshift-multiarch-master-nightly-4.15-ocp-e2e-ovn-ppc64le-powervs-original N/A periodic Registry content changed
periodic-ci-openshift-multiarch-master-nightly-4.18-ocp-e2e-ovn-powervs-capi-multi-p-p N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.19-ppc64le-nightly-powervs-ipi-f14 N/A periodic Registry content changed
periodic-ci-openshift-release-master-ci-4.16-e2e-powervs-ovn-techpreview N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.20-ppc64le-nightly-powervs-ipi-f7 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.16-ppc64le-nightly-powervs-ipi-f28 N/A periodic Registry content changed
periodic-ci-openshift-multiarch-master-nightly-4.14-ocp-e2e-ovn-ppc64le-powervs N/A periodic Registry content changed
periodic-ci-openshift-multiarch-master-nightly-4.13-ocp-e2e-ovn-ppc64le-powervs N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.18-ppc64le-nightly-powervs-ipi-f14 N/A periodic Registry content changed

A total of 33 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 6, 2025

@Neha-dot-Yadav: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants