NO-JIRA: Update the installer golangci-lint to v2.8#75091
NO-JIRA: Update the installer golangci-lint to v2.8#75091vimauro wants to merge 5 commits intoopenshift:mainfrom
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@vimauro: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/pj-rehearse |
|
@vimauro: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/test ci-operator-config |
|
/lgtm |
|
Actually, can you also update 4.22 and 4.23 files as well, since the bump will effect those lanes as well |
Done, thanks! |
|
/pj-rehearse max |
|
@vimauro: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: eggfoobar, vimauro The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/pj-rehearse |
|
@vimauro: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/retest-required |
|
/pj-rehearse pull-ci-openshift-installer-release-4.23-golint pull-ci-openshift-installer-release-4.22-golint pull-ci-openshift-installer-release-5.0-golint pull-ci-openshift-installer-main-golint |
|
@eggfoobar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/reopen Lets see if we still need to update the golint for versions newer than 4.22 |
|
@eggfoobar: Reopened this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@vimauro: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/pj-rehearse pull-ci-openshift-installer-release-4.23-golint pull-ci-openshift-installer-release-4.22-golint pull-ci-openshift-installer-release-5.0-golint pull-ci-openshift-installer-main-golint |
|
@eggfoobar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
New changes are detected. LGTM label has been removed. |
|
/pj-rehearse pull-ci-openshift-installer-release-4.23-golint pull-ci-openshift-installer-release-4.22-golint pull-ci-openshift-installer-release-5.0-golint pull-ci-openshift-installer-main-golint |
|
@eggfoobar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[REHEARSALNOTIFIER]
A total of 470 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse pull-ci-openshift-installer-release-4.23-golint pull-ci-openshift-installer-release-4.22-golint pull-ci-openshift-installer-release-5.0-golint pull-ci-openshift-installer-main-golint |
|
@vimauro: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@vimauro: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
Update the installer golangci-lint to v2.8 (built on GO 1.25)
Related to openshift/installer#10320 where I am upgrading the installer dependencies to GO 1.25