Skip to content

Fix bug with test IDs containing spaces in suite like cluster install#3289

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
dgoodwin:test-runs-with-spaces
Feb 24, 2026
Merged

Fix bug with test IDs containing spaces in suite like cluster install#3289
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
dgoodwin:test-runs-with-spaces

Conversation

@dgoodwin
Copy link
Contributor

@dgoodwin dgoodwin commented Feb 23, 2026

If the test ID suite had a space like "cluster install", the API would reject the request as if you didn't specify test ID at all:

❯ curl https://sippy.dptools.openshift.org/api/tests/v2/runs\?test_id\=cluster%20install%3A0cb1bb27e418491b1ffdacab58c5c8c0\&start_date\=2026-02-16
{"code":400,"message":"test_id parameter is required"}

Summary by CodeRabbit

  • Enhancement
    • Test IDs now support spaces in addition to previously allowed characters (letters, numbers, colon, dot, and hyphen). This enables more flexible and human-readable test naming, broadening accepted naming patterns without changing any public interfaces.

@openshift-ci-robot
Copy link

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 23, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 1fc2267 and 675df92.

📒 Files selected for processing (1)
  • pkg/util/param/param.go
🚧 Files skipped from review as they are similar to previous changes (1)
  • pkg/util/param/param.go

Walkthrough

The test_id parameter regex pattern was expanded to allow spaces in addition to existing characters (word characters, colon, dot, hyphen). The accompanying documentation comment was updated to reflect this change.

Changes

Cohort / File(s) Summary
Parameter Validation
pkg/util/param/param.go
Expanded test_id parameter regex to allow spaces alongside existing word characters, colons, dots, and hyphens. Updated comment with expanded examples.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 7
✅ Passed checks (7 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main bug fix: allowing spaces in test IDs for suite names like 'cluster install'.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Go Error Handling ✅ Passed Code demonstrates proper Go error handling patterns with appropriate context messages, no ignored errors, and correct pointer dereferencing conventions.
Sql Injection Prevention ✅ Passed The test_id parameter regex change allows additional characters but is not used in SQL query construction, preventing SQL injection risks.
Excessive Css In React Should Use Styles ✅ Passed The custom check regarding excessive CSS in React components is not applicable to this pull request. The PR modifies a Go backend file with no React components or styling patterns.
Single Responsibility And Clear Naming ✅ Passed PR maintains single responsibility by updating only a validation regex pattern without expanding package scope or adding new responsibilities.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.5.0)

Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions
The command is terminated due to an error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions


Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot requested review from sosiouxme and stbenjam February 23, 2026 15:28
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 23, 2026
@stbenjam
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 23, 2026
@dgoodwin dgoodwin force-pushed the test-runs-with-spaces branch from 1fc2267 to 675df92 Compare February 23, 2026 17:56
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 23, 2026
@stbenjam
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 23, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 23, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

Scheduling required tests:
/test e2e

@dgoodwin
Copy link
Contributor Author

/override ci/prow/e2e

known issue

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 24, 2026

@dgoodwin: Overrode contexts on behalf of dgoodwin: ci/prow/e2e

Details

In response to this:

/override ci/prow/e2e

known issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 24, 2026

@dgoodwin: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 1c9c6bf into openshift:main Feb 24, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants