Skip to content

Conversation

@siddhanth339
Copy link

A glimpse of the dark theme:

darkTheme1

darkTheme2

darkTheme3

Also, some links were unnecessary so I have fixed them.

@siddhanth339
Copy link
Author

Please review my PR and let me know if any changes are to be made.
Thanks in advance.

@jancborchardt
Copy link
Member

Hi @siddhanth339, good stuff! :) Here’s some points:

What do you think? :)

@siddhanth339
Copy link
Author

Good idea! I am working on it and will make a commit soon. Thanks for your time!

@siddhanth339
Copy link
Author

siddhanth339 commented May 8, 2021

@jancborchardt please review my latest commit 1f42523

  • CSS variables are used and there is only one file "styles.css" for both light and dark themes
  • Toggle for the theme is removed and prefers-color-scheme is used to detect theme
  • Heading is in branded green colour for the dark mode

@siddhanth339
Copy link
Author

@jancborchardt any updates?

@jonatoni jonatoni requested a review from jancborchardt June 15, 2023 12:41
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@siddhanth339 nice! Some feedback:

  • Removing the color completely seems a bit harsh, I would say the top part works nice in the green too? And the dividers would be nice with the dash of color as well. What do you think?
  • Can you check the conflicts with current main branch and resolve them? A lot of this might be because of the tabs to spaces conversion

@jancborchardt jancborchardt requested a review from jonatoni August 9, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants